Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruff] - fix false positive for decorators (RUF028) #14061

Merged
merged 1 commit into from
Nov 3, 2024
Merged

[ruff] - fix false positive for decorators (RUF028) #14061

merged 1 commit into from
Nov 3, 2024

Conversation

diceroll123
Copy link
Contributor

Summary

Allows RUF028 to work for decorators. Fixes #11689

Test Plan

cargo test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added bug Something isn't working rule Implementing or modifying a lint rule labels Nov 3, 2024
@MichaReiser
Copy link
Member

Nice, thank you

@MichaReiser MichaReiser merged commit ae9f08d into astral-sh:main Nov 3, 2024
20 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[preview] RUF028 false positive in decorators.
2 participants
@diceroll123 @MichaReiser