Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ruff on Alpine s390x #10627

Closed
raspbeguy opened this issue Mar 27, 2024 · 4 comments · Fixed by #10869
Closed

Build ruff on Alpine s390x #10627

raspbeguy opened this issue Mar 27, 2024 · 4 comments · Fixed by #10869
Labels
dependencies Pull requests that update a dependency file help wanted Contributions especially welcome

Comments

@raspbeguy
Copy link

Hello, I wish to fix ruff package on Alpine Linux. Currently the package won't build on s390x arch because of a dependancy that won't update its own dependancies. I'm talking about clearscreen which uses an old version on nix which contains a bug for s390x. The bug has been patched on nix but clearscreen seems almost abandoned.

Here is the issue watchexec/clearscreen#20

I don't know rust so I can't contribute, but anyway I think it would be wise to get rid of a dependancy in such state.

@MichaReiser
Copy link
Member

MichaReiser commented Mar 27, 2024

The bug has been patched on nix but clearscreen seems almost abandoned.

It seems that the package is still maintained. The maintainer commented on watchexec/clearscreen#20 with that they're happy to upgrade the nix package once the PR builds successfully.

That's why I think the best forward is to help push the upgrade PR forward rather than vendoring, forking or replacing

An alternative is to use something like crossterm but its clear command but that comes with a lot of functionality that we don't need today.

@MichaReiser MichaReiser added help wanted Contributions especially welcome dependencies Pull requests that update a dependency file labels Mar 27, 2024
@MichaReiser MichaReiser changed the title Get rid of clearscreen as a dependancy Build ruff on Alpine s390x Mar 27, 2024
@charliermarsh
Copy link
Member

I'll try to fix the upstream issue: watchexec/clearscreen#21

@charliermarsh
Copy link
Member

I was able to fix the issue in clearscreen, and the maintainer kindly cut a release. I've upgraded Ruff's version in #10869.

charliermarsh added a commit that referenced this issue Apr 11, 2024
@raspbeguy
Copy link
Author

many thanks @charliermarsh

Glyphack pushed a commit to Glyphack/ruff that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Contributions especially welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants