Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nix to v0.28.0 #21

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Upgrade nix to v0.28.0 #21

merged 1 commit into from
Apr 11, 2024

Conversation

charliermarsh
Copy link
Contributor

@charliermarsh charliermarsh commented Apr 11, 2024

See: #20.

reset_termios(&mut t);
f(&mut t);
tcsetattr(STDIN_FILENO, TCSANOW, &t)?;
tcsetattr(stdin().as_fd(), TCSANOW, &t)?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain if this is the correct way to do this, but it was the easiest way I could find that didn't involve unsafe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(These methods changed to requiring AsFd rather than AsRawFd.)

@passcod
Copy link
Member

passcod commented Apr 11, 2024

Thank you! I'll get this released ASAP

@charliermarsh
Copy link
Contributor Author

Thank you :)

I'm flying slightly blind on the AsFd thing so let me know if that looks off.

@passcod passcod merged commit 03ff232 into watchexec:main Apr 11, 2024
6 checks passed
@charliermarsh charliermarsh deleted the charlie/nix branch April 11, 2024 03:59
@passcod
Copy link
Member

passcod commented Apr 11, 2024

Done in 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants