[flake8-simplify] Avoid double negation in fixes (SIM103)

[MichaReiser]

Summary

This PR stabilizes the fixes improvements made in #15562 (released with ruff 0.9.3 in mid January).

There's no open issue or PR related to the changed fix behavior.

This is not a breaking change. The fix was only gated behind preview to get some more test coverage before releasing.

[codspeed-hq]

CodSpeed Performance Report

Merging #16684 will degrade performances by 4.61%

_{Comparing micha/sim103-fix-improvements (fec9aa3) with micha/ruff-0.10 (464ea4a)}

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	red_knot_check_file[incremental]	5.2 ms	5.5 ms	-4.61%

[github-actions]

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+13 -13 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)

apache/airflow (+6 -6 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- airflow/configuration.py:1278:13: SIM103 Return the condition `not value is None` directly
+ airflow/configuration.py:1278:13: SIM103 Return the condition `value is not None` directly
+ kubernetes_tests/test_base.py:349:9: SIM103 Return the condition `"(no change)" not in patch_configmap_result` directly
- kubernetes_tests/test_base.py:349:9: SIM103 Return the condition `not "(no change)" in patch_configmap_result` directly
- providers/amazon/src/airflow/providers/amazon/aws/sensors/athena.py:94:9: SIM103 Return the condition `not state in self.INTERMEDIATE_STATES` directly
+ providers/amazon/src/airflow/providers/amazon/aws/sensors/athena.py:94:9: SIM103 Return the condition `state not in self.INTERMEDIATE_STATES` directly
- providers/amazon/src/airflow/providers/amazon/aws/sensors/emr.py:316:9: SIM103 Return the condition `not state in self.INTERMEDIATE_STATES` directly
+ providers/amazon/src/airflow/providers/amazon/aws/sensors/emr.py:316:9: SIM103 Return the condition `state not in self.INTERMEDIATE_STATES` directly
- providers/amazon/src/airflow/providers/amazon/aws/sensors/opensearch_serverless.py:110:9: SIM103 Return the condition `not state in self.INTERMEDIATE_STATES` directly
+ providers/amazon/src/airflow/providers/amazon/aws/sensors/opensearch_serverless.py:110:9: SIM103 Return the condition `state not in self.INTERMEDIATE_STATES` directly
+ scripts/ci/pre_commit/check_integrations_list.py:113:9: SIM103 Return the condition `j not in ["Description", "Identifier"]` directly
- scripts/ci/pre_commit/check_integrations_list.py:113:9: SIM103 Return the condition `not j in ["Description", "Identifier"]` directly

apache/superset (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- superset/commands/importers/v1/utils.py:204:5: SIM103 Return the condition `not path.suffix.lower() not in {".yaml", ".yml"}` directly
+ superset/commands/importers/v1/utils.py:204:5: SIM103 Return the condition `path.suffix.lower() in {".yaml", ".yml"}` directly

binary-husky/gpt_academic (+4 -4 violations, +0 -0 fixes)

+ request_llms/bridge_skylark2.py:9:5: SIM103 Return the condition `YUNQUE_SECRET_KEY != ''` directly
- request_llms/bridge_skylark2.py:9:5: SIM103 Return the condition `not YUNQUE_SECRET_KEY == ''` directly
+ request_llms/bridge_taichu.py:12:5: SIM103 Return the condition `TAICHU_API_KEY != ''` directly
- request_llms/bridge_taichu.py:12:5: SIM103 Return the condition `not TAICHU_API_KEY == ''` directly
+ request_llms/bridge_zhipu.py:12:5: SIM103 Return the condition `ZHIPUAI_API_KEY != ''` directly
- request_llms/bridge_zhipu.py:12:5: SIM103 Return the condition `not ZHIPUAI_API_KEY == ''` directly
+ request_llms/com_qwenapi.py:16:13: SIM103 Return the condition `DASHSCOPE_API_KEY != ''` directly
- request_llms/com_qwenapi.py:16:13: SIM103 Return the condition `not DASHSCOPE_API_KEY == ''` directly

zulip/zulip (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- zerver/lib/message.py:1683:5: SIM103 Return the condition `not user_profile.realm != message.get_realm()` directly
+ zerver/lib/message.py:1683:5: SIM103 Return the condition `user_profile.realm == message.get_realm()` directly
+ zerver/views/custom_profile_fields.py:82:5: SIM103 Return the condition `field_data["subtype"] != "custom"` directly
- zerver/views/custom_profile_fields.py:82:5: SIM103 Return the condition `not field_data["subtype"] == "custom"` directly

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
SIM103	26	13	13	0	0

Linter (preview)

✅ ecosystem check detected no linter changes.

[dylwil3]

LGTM!

[ntBre]

Nice, this looks like a much better fix