Skip to content

Conversation

@Kalmaegi
Copy link
Contributor

@Kalmaegi Kalmaegi commented Apr 20, 2025

Summary

This PR add the fix safety section for rule FURB129 in readlines_in_for.rs for #15584

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila added the documentation Improvements or additions to documentation label Apr 21, 2025
@dylwil3 dylwil3 self-assigned this Apr 22, 2025
@dylwil3
Copy link
Collaborator

dylwil3 commented Apr 26, 2025

Thanks for looking into this! I don't think I understand the reasoning you provided - both readlines and directly iterating will consume the stream.

In fact I think this fix should actually be marked as safe , so I'm closing in favor of #17644 (see there for a justification of why I think it ought to be safe).

@dylwil3 dylwil3 closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants