[ty] Add type-expression syntax link to invalid-type-expression

[sharkdp]

Summary

Add a link to this page when emitting invalid-type-expression diagnostics:

[AlexWaygood]

Could you also add the link to this one:

ruff/crates/ty_python_semantic/src/types/infer.rs

Lines 8574 to 8582 in 4b003d9

	KnownInstanceType::ClassVar | KnownInstanceType::Final => {
	if let Some(builder) = self.context.report_lint(&INVALID_TYPE_FORM, subscript) {
	builder.into_diagnostic(format_args!(
	"Type qualifier `{}` is not allowed in type expressions \
	(only in annotation expressions)",
	known_instance.repr(self.db())
	));
	}
	self.infer_type_expression(arguments_slice)

[github-actions]

mypy_primer results

No ecosystem changes detected ✅

[AlexWaygood]

And maybe this one?

ruff/crates/ty_python_semantic/src/types/infer.rs

Lines 8803 to 8809 in 4b003d9

	if let Some(builder) = self.context.report_lint(&INVALID_TYPE_FORM, parameters) {
	builder.into_diagnostic(format_args!(
	"The first argument to `Callable` \
	must be either a list of types, \
	ParamSpec, Concatenate, or `...`",
	));
	}

[AlexWaygood]

And a link in the rule's docs themselves might also be great:

ruff/crates/ty_python_semantic/src/types/diagnostic.rs

Lines 789 to 810 in 68559fc

	declare_lint! {
	/// ## What it does
	/// Checks for expressions that are used as type expressions
	/// but cannot validly be interpreted as such.
	///
	/// ## Why is this bad?
	/// Such expressions cannot be understood by ty.
	/// In some cases, they might raise errors at runtime.
	///
	/// ## Examples
	/// ```python
	/// from typing import Annotated
	///
	/// a: type[1] # `1` is not a type
	/// b: Annotated[int] # `Annotated` expects at least two arguments
	/// ```
	pub(crate) static INVALID_TYPE_FORM = {
	summary: "detects invalid type forms",
	status: LintStatus::preview("1.0.0"),
	default_level: Level::Error,
	}
	}

[AlexWaygood]

Thank you!!

[AlexWaygood]

if you do this then maybe you don't get any line numbers changing in the generated docs :P

Suggested change

	use crate::types::LintDiagnosticGuard;
	use crate::types::{protocol_class::ProtocolClassLiteral, KnownFunction, KnownInstanceType, Type};
	use crate::types::{protocol_class::ProtocolClassLiteral, KnownFunction, KnownInstanceType, LintDiagnosticGuard, Type};