-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[flake8-simplify] enable fix in preview mode (SIM117)
#18208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SIM117 | 356 | 0 | 0 | 356 | 0 |
dylwil3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is great - could you add a test as well? You should be able to just copy the same test fixture path here:
| #[test_case(Rule::IfElseBlockInsteadOfIfExp, Path::new("SIM108.py"))] |
Co-authored-by: Dylan <dylwil3@gmail.com>
Co-authored-by: Dylan <dylwil3@gmail.com>
|
@dylwil3 thanks for the guidance ;-) |
dylwil3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
The PR add the
fix safetysection for ruleSIM117(#15584 ), and enable a fix in preview mode.@dylwil3 Is the first time I'm exposed to the preview mode. So please let me know what should I do/fix. I hope I got what you wanted to say.