Skip to content

[flake8-simplify] Stabilize fix safety of multiple-with-statements (SIM117) #20270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2025
Merged

[flake8-simplify] Stabilize fix safety of multiple-with-statements (SIM117) #20270

merged 4 commits into from
Sep 5, 2025

Conversation

@dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Sep 5, 2025 •
edited
Loading

Introduced in #18208. Removed gating, updated tests and docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +436 -0 fixes in 5 projects; 50 projects unchanged)

apache/airflow (+0 -0 violations, +318 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- airflow-core/src/airflow/cli/commands/rotate_fernet_key_command.py:36:5: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/src/airflow/cli/commands/rotate_fernet_key_command.py:36:5: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/always/test_secrets_local_filesystem.py:401:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/always/test_secrets_local_filesystem.py:401:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/always/test_secrets_local_filesystem.py:413:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/always/test_secrets_local_filesystem.py:413:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/always/test_secrets_local_filesystem.py:427:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/always/test_secrets_local_filesystem.py:427:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/api/common/test_mark_tasks.py:39:5: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/api/common/test_mark_tasks.py:39:5: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/api/common/test_mark_tasks.py:66:5: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/api/common/test_mark_tasks.py:66:5: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/api/common/test_mark_tasks.py:95:5: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/api/common/test_mark_tasks.py:95:5: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_structure.py:697:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_structure.py:697:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py:1902:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py:1902:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/cli/commands/test_dag_command.py:325:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/cli/commands/test_dag_command.py:325:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/cli/commands/test_dag_command.py:345:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/cli/commands/test_dag_command.py:345:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/cli/commands/test_dag_command.py:384:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/cli/commands/test_dag_command.py:384:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/cli/commands/test_variable_command.py:261:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/cli/commands/test_variable_command.py:261:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/cli/commands/test_variable_command.py:437:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/cli/commands/test_variable_command.py:437:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/cli/commands/test_variable_command.py:495:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/cli/commands/test_variable_command.py:495:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/core/test_configuration.py:1211:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/core/test_configuration.py:1211:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/core/test_configuration.py:1584:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/core/test_configuration.py:1584:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- airflow-core/tests/unit/core/test_configuration.py:1782:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ airflow-core/tests/unit/core/test_configuration.py:1782:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
... 282 additional changes omitted for project

apache/superset (+0 -0 violations, +62 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- superset/db_engine_specs/gsheets.py:376:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ superset/db_engine_specs/gsheets.py:376:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- superset/models/core.py:579:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ superset/models/core.py:579:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- superset/sql_lab.py:658:5: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ superset/sql_lab.py:658:5: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- tests/conftest.py:73:5: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ tests/conftest.py:73:5: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- tests/integration_tests/dashboards/commands_tests.py:781:13: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ tests/integration_tests/dashboards/commands_tests.py:781:13: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
... 52 additional changes omitted for project

binary-husky/gpt_academic (+0 -0 violations, +10 -0 fixes) 

- crazy_functions/review_fns/data_sources/openalex_source.py:115:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ crazy_functions/review_fns/data_sources/openalex_source.py:115:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- crazy_functions/review_fns/data_sources/openalex_source.py:22:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ crazy_functions/review_fns/data_sources/openalex_source.py:22:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- crazy_functions/review_fns/data_sources/openalex_source.py:88:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ crazy_functions/review_fns/data_sources/openalex_source.py:88:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- crazy_functions/review_fns/data_sources/openalex_source.py:99:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ crazy_functions/review_fns/data_sources/openalex_source.py:99:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- crazy_functions/review_fns/data_sources/unpaywall_source.py:14:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ crazy_functions/review_fns/data_sources/unpaywall_source.py:14:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements

bokeh/bokeh (+0 -0 violations, +44 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- src/bokeh/application/handlers/code.py:157:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ src/bokeh/application/handlers/code.py:157:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- tests/unit/bokeh/command/subcommands/test_json__subcommands.py:92:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ tests/unit/bokeh/command/subcommands/test_json__subcommands.py:92:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- tests/unit/bokeh/command/subcommands/test_serve.py:584:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ tests/unit/bokeh/command/subcommands/test_serve.py:584:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- tests/unit/bokeh/command/subcommands/test_serve.py:612:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ tests/unit/bokeh/command/subcommands/test_serve.py:612:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
- tests/unit/bokeh/command/subcommands/test_serve.py:629:9: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
+ tests/unit/bokeh/command/subcommands/test_serve.py:629:9: SIM117 [*] Use a single `with` statement with multiple contexts instead of nested `with` statements
... 34 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
SIM117 436 0 0 436 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@dylwil3 dylwil3 merged commit 3db783d into brent/0.13.0 Sep 5, 2025
35 checks passed
@dylwil3 dylwil3 deleted the dylan/stabilize-sim-fix branch September 5, 2025 19:14
@dylwil3 dylwil3 mentioned this pull request Sep 5, 2025
Merged
2 tasks
ntBre pushed a commit that referenced this pull request Sep 8, 2025
@dylwil3 @ntBre
[flake8-simplify] Stabilize fix safety of `multiple-with-statements…
73a7085 
…` (`SIM117`) (#20270)

Introduced in #18208. Removed gating, updated tests and docs.
@ntBre ntBre added the fixes Related to suggested fixes for violations label Sep 8, 2025
ntBre pushed a commit that referenced this pull request Sep 10, 2025
@dylwil3 @ntBre
[flake8-simplify] Stabilize fix safety of `multiple-with-statements…
c1d4378 
…` (`SIM117`) (#20270)

Introduced in #18208. Removed gating, updated tests and docs.
ntBre pushed a commit that referenced this pull request Sep 10, 2025
@dylwil3 @ntBre
[flake8-simplify] Stabilize fix safety of `multiple-with-statements…
7a5036f 
…` (`SIM117`) (#20270)

Introduced in #18208. Removed gating, updated tests and docs.
ntBre pushed a commit that referenced this pull request Sep 10, 2025
@dylwil3 @ntBre
[flake8-simplify] Stabilize fix safety of `multiple-with-statements…
9d972d0 
…` (`SIM117`) (#20270)

Introduced in #18208. Removed gating, updated tests and docs.
dcreager added a commit that referenced this pull request Sep 10, 2025
@dcreager
Merge branch 'main' into dcreager/constraint-mdtest
8bded2b 
* main: (26 commits)
  Ignore deprecated rules unless selected by exact code (#20167)
  Stabilize adding future import via config option (#20277)
  [`flake8-errmsg`] Stabilize extending `raw-string-in-exception` (`EM101`) to support byte strings (#20273)
  Stabilize the remaining Airflow rules (#20250)
  [`flake8-bugbear`] Stabilize support for non-context-manager calls in `assert-raises-exception` (`B017`) (#20274)
  [`flake8-commas`] Stabilize support for trailing comma checks in type parameter lists (`COM812`, `COM819`) (#20275)
  [`pygrep_hooks`] Stabilize using`AsyncMock` methods in `invalid-mock-access` (`PGH005`) (#20272)
  Stabilize new strategy for classifying imports as first party (#20268)
  [`pylint`] Stabilize ignoring `__init__.py` for `useless-import-alias` (`PLC0414`) (#20271)
  [`pylint`] Stabilize adding U+061C to `bidirectional-unicode` (`PLE2502`) (#20276)
  [`flake8-simplify`] Stabilize fix safety of `multiple-with-statements` (`SIM117`) (#20270)
  Stabilize `pytest-raises-ambiguous-pattern` (`RUF043`) (#20253)
  Stabilize `f-string-number-format` (`FURB116`) (#20247)
  [`pyupgrade`] Remove `non-pep604-isinstance` (`UP038`) (#19156)
  [`pandas-vet`] Remove `pandas-df-variable-name` (`PD901`) (#19223)
  Remove deprecated macOS config file discovery (#19210)
  Stabilize `redundant-none-literal` (`PYI061`) (#20236)
  Stabilize `generic-not-last-base-class` (`PYI059`) (#20246)
  Stabilize `useless-class-metaclass-type` (`UP050`) (#20230)
  Stabilize `os-symlink` (`PTH211`) (#20229)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amyreese amyreese amyreese approved these changes

Assignees

No one assigned

Labels

fixes Related to suggested fixes for violations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dylwil3 @amyreese @ntBre