Stabilize f-string-number-format (FURB116)
#20247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests and docs look good
Contributor
|
amyreese
approved these changes
Sep 4, 2025
AlexWaygood
approved these changes
Sep 5, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Not sure I agree with the docs here that using an f-string is more readable than using oct() 😄
But the FURB rules are often pretty opinionated, and it's fairly easy to disable the rule if you disagree, I guess
Contributor
Author
|
Ah really?? I guess neither of them is really that readable, but I thought the f-string was slightly better 😆 We can hold off if you feel strongly, I'm happy either way. |
Member
|
I don't have a strong opinion. I don't think either |
ntBre
added a commit
that referenced
this pull request
Sep 8, 2025
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
dcreager
added a commit
that referenced
this pull request
Sep 10, 2025
* main: (26 commits) Ignore deprecated rules unless selected by exact code (#20167) Stabilize adding future import via config option (#20277) [`flake8-errmsg`] Stabilize extending `raw-string-in-exception` (`EM101`) to support byte strings (#20273) Stabilize the remaining Airflow rules (#20250) [`flake8-bugbear`] Stabilize support for non-context-manager calls in `assert-raises-exception` (`B017`) (#20274) [`flake8-commas`] Stabilize support for trailing comma checks in type parameter lists (`COM812`, `COM819`) (#20275) [`pygrep_hooks`] Stabilize using`AsyncMock` methods in `invalid-mock-access` (`PGH005`) (#20272) Stabilize new strategy for classifying imports as first party (#20268) [`pylint`] Stabilize ignoring `__init__.py` for `useless-import-alias` (`PLC0414`) (#20271) [`pylint`] Stabilize adding U+061C to `bidirectional-unicode` (`PLE2502`) (#20276) [`flake8-simplify`] Stabilize fix safety of `multiple-with-statements` (`SIM117`) (#20270) Stabilize `pytest-raises-ambiguous-pattern` (`RUF043`) (#20253) Stabilize `f-string-number-format` (`FURB116`) (#20247) [`pyupgrade`] Remove `non-pep604-isinstance` (`UP038`) (#19156) [`pandas-vet`] Remove `pandas-df-variable-name` (`PD901`) (#19223) Remove deprecated macOS config file discovery (#19210) Stabilize `redundant-none-literal` (`PYI061`) (#20236) Stabilize `generic-not-last-base-class` (`PYI059`) (#20246) Stabilize `useless-class-metaclass-type` (`UP050`) (#20230) Stabilize `os-symlink` (`PTH211`) (#20229) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and docs look good