Skip to content

Stabilize generic-not-last-base-class (PYI059) #20246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Stabilize generic-not-last-base-class (PYI059) #20246

merged 1 commit into from
Sep 4, 2025

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Sep 4, 2025

Tests and docs look good

We nearly stabilized this last time (#18601), but it needed one more bug fix and a documentation improvement (#18611)

@ntBre
Stabilize generic-not-last-base-class (PYI059)
cbc917a 
Tests and docs look good

We nearly stabilized this last
time (#18601) but it needed one more bug
fix and a documentation improvement (#18611)
@ntBre ntBre added this to the v0.13 milestone Sep 4, 2025
@ntBre ntBre added the rule Implementing or modifying a lint rule label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+10 -0 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)

apache/airflow (+5 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:77:22: PYI059 `Generic[]` should always be the last base class
+ airflow-core/src/airflow/api_fastapi/common/exceptions.py:38:23: PYI059 `Generic[]` should always be the last base class
+ airflow-core/src/airflow/api_fastapi/core_api/base.py:52:16: PYI059 `Generic[]` should always be the last base class
+ airflow-core/src/airflow/api_fastapi/core_api/services/public/common.py:37:18: PYI059 `Generic[]` should always be the last base class
+ devel-common/src/tests_common/pytest_plugin.py:780:15: PYI059 `Generic[]` should always be the last base class

latchbio/latch (+2 -0 violations, +0 -0 fixes) 

+ src/latch/types/metadata.py:437:25: PYI059 `Generic[]` should always be the last base class
+ src/latch/types/metadata.py:486:24: PYI059 `Generic[]` should always be the last base class

python/typeshed (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/asyncio/queues.pyi:29:12: PYI059 `Generic[]` should always be the last base class

zulip/zulip (+2 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ zerver/lib/notes.py:12:16: PYI059 `Generic[]` should always be the last base class
+ zerver/lib/queue.py:35:18: PYI059 `Generic[]` should always be the last base class

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PYI059 10 10 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre
Copy link
Contributor Author

ntBre commented Sep 4, 2025

This ecosystem hit from typeshed seems interesting, but maybe okay? Everything else looks as expected to me.

https://github.com/python/typeshed/blob/07557a4316d246b4315f600fd4c9734297d6bc92/stdlib/asyncio/queues.pyi#L27-L29

@ntBre ntBre marked this pull request as ready for review September 4, 2025 19:58
@ntBre ntBre requested a review from AlexWaygood September 4, 2025 19:58
@ntBre ntBre merged commit f416e84 into brent/0.13.0 Sep 4, 2025
36 checks passed
@ntBre ntBre deleted the brent/pyi059 branch September 4, 2025 23:06
@ntBre ntBre mentioned this pull request Sep 4, 2025
Merged
2 tasks
ntBre added a commit that referenced this pull request Sep 8, 2025
@ntBre
Stabilize generic-not-last-base-class (PYI059) (#20246)
f2cfc11 
Tests and docs look good

We nearly stabilized this last time
(#18601), but it needed one more
bug fix and a documentation improvement
(#18611)
ntBre added a commit that referenced this pull request Sep 10, 2025
@ntBre
Stabilize generic-not-last-base-class (PYI059) (#20246)
c7b595c 
Tests and docs look good

We nearly stabilized this last time
(#18601), but it needed one more
bug fix and a documentation improvement
(#18611)
ntBre added a commit that referenced this pull request Sep 10, 2025
@ntBre
Stabilize generic-not-last-base-class (PYI059) (#20246)
90b494b 
Tests and docs look good

We nearly stabilized this last time
(#18601), but it needed one more
bug fix and a documentation improvement
(#18611)
ntBre added a commit that referenced this pull request Sep 10, 2025
@ntBre
Stabilize generic-not-last-base-class (PYI059) (#20246)
e139104 
Tests and docs look good

We nearly stabilized this last time
(#18601), but it needed one more
bug fix and a documentation improvement
(#18611)
dcreager added a commit that referenced this pull request Sep 10, 2025
@dcreager
Merge branch 'main' into dcreager/constraint-mdtest
8bded2b 
* main: (26 commits)
  Ignore deprecated rules unless selected by exact code (#20167)
  Stabilize adding future import via config option (#20277)
  [`flake8-errmsg`] Stabilize extending `raw-string-in-exception` (`EM101`) to support byte strings (#20273)
  Stabilize the remaining Airflow rules (#20250)
  [`flake8-bugbear`] Stabilize support for non-context-manager calls in `assert-raises-exception` (`B017`) (#20274)
  [`flake8-commas`] Stabilize support for trailing comma checks in type parameter lists (`COM812`, `COM819`) (#20275)
  [`pygrep_hooks`] Stabilize using`AsyncMock` methods in `invalid-mock-access` (`PGH005`) (#20272)
  Stabilize new strategy for classifying imports as first party (#20268)
  [`pylint`] Stabilize ignoring `__init__.py` for `useless-import-alias` (`PLC0414`) (#20271)
  [`pylint`] Stabilize adding U+061C to `bidirectional-unicode` (`PLE2502`) (#20276)
  [`flake8-simplify`] Stabilize fix safety of `multiple-with-statements` (`SIM117`) (#20270)
  Stabilize `pytest-raises-ambiguous-pattern` (`RUF043`) (#20253)
  Stabilize `f-string-number-format` (`FURB116`) (#20247)
  [`pyupgrade`] Remove `non-pep604-isinstance` (`UP038`) (#19156)
  [`pandas-vet`] Remove `pandas-df-variable-name` (`PD901`) (#19223)
  Remove deprecated macOS config file discovery (#19210)
  Stabilize `redundant-none-literal` (`PYI061`) (#20236)
  Stabilize `generic-not-last-base-class` (`PYI059`) (#20246)
  Stabilize `useless-class-metaclass-type` (`UP050`) (#20230)
  Stabilize `os-symlink` (`PTH211`) (#20229)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

v0.13

Development

Successfully merging this pull request may close these issues.

3 participants

@ntBre @AlexWaygood