[ty] Fix panic when trying to pull types for attribute expressions inside Literal type expressions
#18535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side `Literal` type expressions
AlexWaygood
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We weren't storing the type for attribute expressions inside
Literalslices. This was causing us to panic when pulling types on four typeshed files.Test Plan
Added a corpus test that previously failed and removed four entries from the
KNOWN_FAILUREScorpus test ignorelist. All existing tests pass.