chore(deps): upgrade mkdocs-github-admonitions-plugin to v0.1.1 #19375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renovate doesn't upgrade sha-pinned dependencies. The pin was introduced due to the bug fix not being available in a released version in PR astral-sh#18163 Now the bug fix has been released so the pin can be removed. In the future, in such cases, it might be a good idea to add a comment and/or set a reminder to look back and consider removing the pin as renovate will not handle sha pins. As renovate handles almost all dep upgrades, this provides a false sense of "security" that deps are always kept up to date automatically. Related to issue astral-sh#19369 Thanks @ntBre for the pointer!
Member
|
I'm not sure if we even use this version in the deployed docs but @zanieb will know better |
Contributor
Author
|
@MichaReiser oh interesting, if the prod setup differs from what's on main, that might be a good thing to add the docs CONTRIBUTING.md section Maybe as an addition to: |
MichaReiser
requested changes
Jul 16, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thank you. We should also update the regular requirements.txt file so that both insiders/non-insiders use the same versions (where possible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renovate doesn't upgrade sha-pinned dependencies.
A sha pin on
└mkdocs-github-admonitions-pluginwas introduced due to a bug fix not being available in a released version in PR #18163Now the bug fix has been released so the pin can be removed.
In the future, in such cases, it might be a good idea to add a comment
and/or set a reminder to look back and consider removing the pin
as renovate will not handle sha pins.
As renovate handles almost all dep upgrades, this provides a false sense
of "security" that deps are always kept up to date automatically.
Related to issue #19369
Thanks @ntBre for the pointer!
Test Plan
Docs previews should be visually inspected for correct rendering of admonitions.
As I'm not an Astral insider, I unfortunately can't actually faithfully reproduce the docs (due to Material for MkDocs being closed source). I don't know if there are automatic preview builds in CI that I can inspect instead.
Other
I also add a comment to remind the reader that renovate does not automatically update git/sha pinned dependencies. This was touched on in #19369 as well - I think this comment might be worth it but happy to remove of course if reviewers differ. It's not a big change, hence adding as piggyback commit to the PR that edits the same file.