Skip to content

Conversation

@UnboundVariable
Copy link
Collaborator

This PR adds support for the "document highlights" feature in the ty playground.

}
}

// TODO: Handle string literals that map to TypedDict fields
Copy link
Collaborator Author

@UnboundVariable UnboundVariable Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I purposely removed this TODO. It's unrelated to the other parts of this PR, but this was a convenient time to remove it. I previously thought that "goto" for TypedDict subscripts was supported in pylance, but it turns out it is not supported. While this is something that could certainly be added at some point in the future, we should probably wait for users to request it before making it a priority.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@AlexWaygood AlexWaygood removed their request for review July 24, 2025 21:22
@MichaReiser MichaReiser added playground A playground-specific issue ty Multi-file analysis & type inference labels Jul 25, 2025
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll waiting for the moment where this all becomes too much and we'll need to rewrite the playground to run ty in a web worker. Probably something that claude can help us when we reach that point

@UnboundVariable UnboundVariable merged commit 4a4dc38 into astral-sh:main Jul 25, 2025
39 checks passed
@UnboundVariable UnboundVariable deleted the highlights_playground branch July 25, 2025 15:55
AlexWaygood pushed a commit that referenced this pull request Jul 25, 2025
This PR adds support for the "document highlights" feature in the ty
playground.

---------

Co-authored-by: UnboundVariable <unbound@gmail.com>
dcreager added a commit that referenced this pull request Jul 25, 2025
* main:
  [ty] Added support for "document symbols" and "workspace symbols" (#19521)
  Add `TextEmitter::with_color` and disable colors in `unreadable_files` test (#19562)
  [ty] Added support for document highlights in playground. (#19540)
  [`refurb`] Ignore decorated functions for `FURB118` (#19339)
  [ty] Add workflow to comment diagnostic diff for conformance tests (#19556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playground A playground-specific issue ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants