-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] Added support for document highlights in playground. #19540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ty] Added support for document highlights in playground. #19540
Conversation
| } | ||
| } | ||
|
|
||
| // TODO: Handle string literals that map to TypedDict fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I purposely removed this TODO. It's unrelated to the other parts of this PR, but this was a convenient time to remove it. I previously thought that "goto" for TypedDict subscripts was supported in pylance, but it turns out it is not supported. While this is something that could certainly be added at some point in the future, we should probably wait for users to request it before making it a priority.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I'll waiting for the moment where this all becomes too much and we'll need to rewrite the playground to run ty in a web worker. Probably something that claude can help us when we reach that point
This PR adds support for the "document highlights" feature in the ty playground. --------- Co-authored-by: UnboundVariable <unbound@gmail.com>
* main: [ty] Added support for "document symbols" and "workspace symbols" (#19521) Add `TextEmitter::with_color` and disable colors in `unreadable_files` test (#19562) [ty] Added support for document highlights in playground. (#19540) [`refurb`] Ignore decorated functions for `FURB118` (#19339) [ty] Add workflow to comment diagnostic diff for conformance tests (#19556)
This PR adds support for the "document highlights" feature in the ty playground.