Add TextEmitter::with_color and disable colors in unreadable_files test
#19562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` test Summary -- I looked at other uses of `TextEmitter`, and I think this should be the only one affected by this. The other integration tests must work properly since they're run with `assert_cmd_snapshot!`, which I assume triggers the `SHOULD_COLORIZE` case, and the `cfg!(test)` check will work for uses in `ruff_linter`. https://github.com/astral-sh/ruff/blob/4a4dc38b5b5055601dcb8da4ad07720e47d451fa/crates/ruff_linter/src/message/text.rs#L36-L44 Test Plan -- `cargo test -p ruff`, which was failing on `main` with color codes in the output before this
MichaReiser
approved these changes
Jul 25, 2025
Contributor
|
dcreager
added a commit
that referenced
this pull request
Jul 25, 2025
* main: [ty] Added support for "document symbols" and "workspace symbols" (#19521) Add `TextEmitter::with_color` and disable colors in `unreadable_files` test (#19562) [ty] Added support for document highlights in playground. (#19540) [`refurb`] Ignore decorated functions for `FURB118` (#19339) [ty] Add workflow to comment diagnostic diff for conformance tests (#19556)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I looked at other uses of
TextEmitter, and I think this should be the only one affected by this. The other integration tests must work properly since they're run withassert_cmd_snapshot!, which I assume triggers theSHOULD_COLORIZEcase, and thecfg!(test)check will work for uses inruff_linter.ruff/crates/ruff_linter/src/message/text.rs
Lines 36 to 44 in 4a4dc38
Alternatively, we could probably move this to a CLI test instead.
Test Plan
cargo test -p ruff, which was failing onmainwith color codes in the output before this