[ty] Inlay hint call argument location #20349

MatthewMckee4 · 2025-09-11T12:17:49Z

Summary

Adds location to the inlay hint label part for call arguments. This allows "goto" on the inlay hint.

inlay-hint-call-argument-location.webm

This has not been added to the playground as Monaco doesn't support it.

Test Plan

updated a test in ty_server. But other than that im not sure the best way to approach tests for this.

github-actions · 2025-09-11T12:20:28Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

github-actions · 2025-09-11T12:22:55Z

`mypy_primer` results

Changes were detected when running on open source projects

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
- src/scikit_build_core/build/wheel.py:98:20: error[no-matching-overload] No overload of bound method `__init__` matches arguments
- Found 44 diagnostics
+ Found 43 diagnostics

No memory usage changes detected ✅

MatthewMckee4 · 2025-09-11T12:26:19Z

Getting this error in playground. It seems like i have broken the goto as well as the inlay hint location still not working. will look into this more

Uncaught Error: can't access property "monaco", this is undefined

mapNavigationTarget@http://localhost:5173/src/Editor/Editor.tsx:464:13
mapNavigationTargets@http://localhost:5173/src/Editor/Editor.tsx:495:22
provideDefinition@http://localhost:5173/src/Editor/Editor.tsx:391:21

dhruvmanila · 2025-09-13T04:09:09Z

Getting this error in playground. It seems like i have broken the goto as well as the inlay hint location still not working. will look into this more

I'd be happy to keep the playground changes in a separate PR to get the LSP changes in.

MatthewMckee4 · 2025-09-13T17:24:45Z

I fixed this error, was a small issue, I fixed in the "Fix Playground" commit

MichaReiser · 2025-09-15T12:45:29Z

I fixed this error, was a small issue, I fixed in the "Fix Playground" commit

Nice. Does that mean this PR is now ready for review or is there more to do?

MatthewMckee4 · 2025-09-15T13:55:08Z

I am just looking over it for the final time now, will make it ready for review today

crates/ty_python_semantic/src/types/ide_support.rs

MichaReiser · 2025-09-16T07:29:52Z

@Gankra is this a PR you could take a look at? If not, that's fine. It might just take me a few days before I get to it because I'm still catching up with notifications after my PTO (and have some other time sensitive things that I need to do first)

Gankra

The basic approach seems reasonable! I was going to complain that this approach doesn't properly play with stub-mapping and the goto-definition vs goto-declaration distinction, but after looking at the fields provided by the spec it seems like it really does only let you pick one "target" for the inlay hint.

That said the implementation you've chosen implements goto-declaration semantics which is not the default for a cmd+click, which prefers goto-definition. I think it would be fine to have that be a followup, as this is already seemingly strictly better than what pylance does!

crates/ty_python_semantic/src/types/ide_support.rs

MatthewMckee4 · 2025-09-22T20:41:28Z

working fine in vscode, just need to look into the playground not working

MatthewMckee4 · 2025-09-22T21:05:39Z

really have no clue why it isnt working

MichaReiser

really have no clue why it isnt working

Do you mean that the inlay's aren't clickable. I somewhat suspect that this isn't implemented in monaco.

I tried to find an inlay example but couldn't find any (the TypeScript playground also doesn't use inlays). It's quiet possible that monaco doesn't support clickable inlays?

crates/ty_wasm/src/lib.rs

MichaReiser · 2025-09-23T16:40:40Z

playground/ty/src/Editor/Editor.tsx

-        label: hint.markdown,
+        label: hint.label.map((part) => ({
+          label: part.label,
+          location:


Given that this doesn't work in Monaco (it seems) I'm inclined to not set location and instead at a comment saying that. As of today (date), location isn't supported by Monaco which is why the field is ommited in the playground.

yeah that makes sense, will update. Thanks

I think it would be good to keep all of the updates to ty_wasm, just incase in the future monaco supports this, what do you think?

Yeah, I think that's fine. I also don't expect the ty_wasm code to add too much overhead. It only maps a few locations

MichaReiser · 2025-09-24T07:54:47Z

@Gankra would you mind taking another look at this PR (The playground changes look good to me)

MatthewMckee4 · 2025-10-21T16:46:17Z

I understand this isn't important for the beta but just making sure this doesn't get lost.

MichaReiser · 2025-10-21T16:58:10Z

Thanks. I think it got lost 😓 I'll take another look tomorrow and another ping to @Gankra

MatthewMckee4 · 2025-10-21T21:55:23Z

Thank you

crates/ty_ide/src/inlay_hints.rs

crates/ty_python_semantic/src/types/ide_support.rs

MichaReiser · 2025-10-22T12:48:37Z

Let me know when this is ready for re-review (you can request a review)

* origin/main: (26 commits) Mention `force-exclude` in "Configuration > Python file discovery" (#21500) Avoid syntax error when formatting attribute expressions with outer parentheses, parenthesized value, and trailing comment on value (#20418) [ty] suppress invalid suggestions in import statements (#21484) Limit `eglot-format` hook to eglot-managed Python buffers (#21459) Adjust own-line comment placement between branches (#21185) [ty] Subscript assignment diagnostics follow-up (#21452) [ty] Inlay hint call argument location (#20349) [ty] Use `CompactStr` for `StringLiteralType` (#21497) Update CodSpeedHQ/action action to v4.3.4 (#21488) Update salsa digest to a885bb4 (#21486) Update dependency ruff to v0.14.5 (#21489) Update astral-sh/setup-uv action to v7.1.3 (#21487) Update Rust crate get-size2 to v0.7.2 (#21490) Update Rust crate indicatif to v0.18.3 (#21491) Update Rust crate quick-junit to v0.5.2 (#21492) Update taiki-e/install-action action to v2.62.52 (#21493) Fix analyze graph tests on windows (#21481) `analyze`: Add option to skip over imports in `TYPE_CHECKING` blocks (#21472) [ty] Dataclasses: `__hash__` semantics and `unsafe_hash` (#21470) [ty] Dataclass transform: complete set of parameters (#21474) ...

* dcreager/coolable: (31 commits) mdformat don't panic Mention `force-exclude` in "Configuration > Python file discovery" (#21500) Avoid syntax error when formatting attribute expressions with outer parentheses, parenthesized value, and trailing comment on value (#20418) [ty] suppress invalid suggestions in import statements (#21484) known discrepancy TODO α-rename todo equiv too Limit `eglot-format` hook to eglot-managed Python buffers (#21459) Adjust own-line comment placement between branches (#21185) [ty] Subscript assignment diagnostics follow-up (#21452) [ty] Inlay hint call argument location (#20349) [ty] Use `CompactStr` for `StringLiteralType` (#21497) Update CodSpeedHQ/action action to v4.3.4 (#21488) Update salsa digest to a885bb4 (#21486) Update dependency ruff to v0.14.5 (#21489) Update astral-sh/setup-uv action to v7.1.3 (#21487) Update Rust crate get-size2 to v0.7.2 (#21490) Update Rust crate indicatif to v0.18.3 (#21491) Update Rust crate quick-junit to v0.5.2 (#21492) ...

Inlay hint call argument location

78dff3b

AlexWaygood changed the title ~~Inlay hint call argument location~~ [ty] Inlay hint call argument location Sep 11, 2025

AlexWaygood added server Related to the LSP server ty Multi-file analysis & type inference labels Sep 11, 2025

MatthewMckee4 added 6 commits September 11, 2025 14:06

Fix playground

9f0bba6

Add tests for inlay hint label locations

de80e73

Comments

e1896cd

Update snapshots output

4a142eb

Fix windows test by using local import

2726a6e

Small changes

3378713

MatthewMckee4 commented Sep 15, 2025

View reviewed changes

crates/ty_python_semantic/src/types/ide_support.rs Outdated Show resolved Hide resolved

Small changes

e3b6616

MatthewMckee4 marked this pull request as ready for review September 15, 2025 14:07

MatthewMckee4 requested review from AlexWaygood, MichaReiser, carljm, dcreager and sharkdp as code owners September 15, 2025 14:07

Gankra approved these changes Sep 18, 2025

View reviewed changes

crates/ty_python_semantic/src/types/ide_support.rs Outdated Show resolved Hide resolved

crates/ty_python_semantic/src/types/ide_support.rs Outdated Show resolved Hide resolved

crates/ty_python_semantic/src/types/ide_support.rs Outdated Show resolved Hide resolved

AlexWaygood removed their request for review September 18, 2025 06:42

sharkdp removed their request for review September 18, 2025 06:49

Merge main

6c38f77

Add test for function with weird formatting

1f74a1c

MichaReiser reviewed Sep 23, 2025

View reviewed changes

crates/ty_wasm/src/lib.rs Outdated Show resolved Hide resolved

MatthewMckee4 added 4 commits September 23, 2025 16:36

Use FileRange

20364f1

Address review

7d70368

Merge main

64194dc

Merge main

130e6c9

MichaReiser reviewed Sep 23, 2025

View reviewed changes

Dont use location field in playground

37c3c4e

MatthewMckee4 added 3 commits October 21, 2025 17:35

Merge main

05cb46c

Fix merge conflicts

595dc90

Fix merge conflicts

6d9387d

Merge branch 'main' into inlay-hint-call-argument-location

1522cbd

MichaReiser reviewed Oct 22, 2025

View reviewed changes

Update snapshots

52f36d0

Add get_definition_parameter_range

58fe441

MatthewMckee4 requested a review from MichaReiser October 22, 2025 13:01

MichaReiser added 2 commits November 17, 2025 10:11

Merge branch 'main' into inlay-hint-call-argument-location

bad0f0f

Nits

3006711

MichaReiser force-pushed the inlay-hint-call-argument-location branch from 7441715 to 3006711 Compare November 17, 2025 09:27

Discard changes to crates/ty_ide/src/signature_help.rs

2355627

MichaReiser merged commit 901e9cd into astral-sh:main Nov 17, 2025
41 checks passed

[ty] Inlay hint call argument location #20349

[ty] Inlay hint call argument location #20349

Conversation

MatthewMckee4 commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

github-actions bot commented Sep 11, 2025 • edited by astral-sh-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

github-actions bot commented Sep 11, 2025 • edited by astral-sh-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

MatthewMckee4 commented Sep 11, 2025

Uh oh!

dhruvmanila commented Sep 13, 2025

Uh oh!

MatthewMckee4 commented Sep 13, 2025

Uh oh!

MichaReiser commented Sep 15, 2025

Uh oh!

MatthewMckee4 commented Sep 15, 2025

Uh oh!

Uh oh!

MichaReiser commented Sep 16, 2025

Uh oh!

Gankra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MatthewMckee4 commented Sep 22, 2025

Uh oh!

MatthewMckee4 commented Sep 22, 2025

Uh oh!

MichaReiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MichaReiser Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

MatthewMckee4 Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

MatthewMckee4 Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser commented Sep 24, 2025

Uh oh!

MatthewMckee4 commented Oct 21, 2025

Uh oh!

MichaReiser commented Oct 21, 2025

Uh oh!

MatthewMckee4 commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaReiser commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MatthewMckee4 commented Sep 11, 2025 •

edited

Loading

github-actions bot commented Sep 11, 2025 •

edited by astral-sh-bot bot

Loading

github-actions bot commented Sep 11, 2025 •

edited by astral-sh-bot bot

Loading

`mypy_primer` results