[ty] Dataclasses: __hash__ semantics and unsafe_hash
#21470
Merged
+86
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
requested review from
AlexWaygood,
carljm and
dcreager
as code owners
19 tasks
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
|
This comment was marked as resolved.
This comment was marked as resolved.
sharkdp
force-pushed
the
david/dataclass-unsafe_hash
branch
from
1dfb11b to
0d750c7
Compare
sharkdp
force-pushed
the
david/dataclass-unsafe_hash
branch
from
0d750c7 to
d1a8461
Compare
sharkdp
changed the base branch from
main
to
david/dataclass-transform-remaining-flags
AlexWaygood
approved these changes
Nov 15, 2025
sharkdp
force-pushed
the
david/dataclass-transform-remaining-flags
branch
from
3e52af4 to
528afe2
Compare
Base automatically changed from
david/dataclass-transform-remaining-flags
to
main
November 16, 2025 09:46
sharkdp
force-pushed
the
david/dataclass-unsafe_hash
branch
from
d1a8461 to
7793223
Compare
dcreager
added a commit
that referenced
this pull request
Nov 17, 2025
* origin/main: (26 commits) Mention `force-exclude` in "Configuration > Python file discovery" (#21500) Avoid syntax error when formatting attribute expressions with outer parentheses, parenthesized value, and trailing comment on value (#20418) [ty] suppress invalid suggestions in import statements (#21484) Limit `eglot-format` hook to eglot-managed Python buffers (#21459) Adjust own-line comment placement between branches (#21185) [ty] Subscript assignment diagnostics follow-up (#21452) [ty] Inlay hint call argument location (#20349) [ty] Use `CompactStr` for `StringLiteralType` (#21497) Update CodSpeedHQ/action action to v4.3.4 (#21488) Update salsa digest to a885bb4 (#21486) Update dependency ruff to v0.14.5 (#21489) Update astral-sh/setup-uv action to v7.1.3 (#21487) Update Rust crate get-size2 to v0.7.2 (#21490) Update Rust crate indicatif to v0.18.3 (#21491) Update Rust crate quick-junit to v0.5.2 (#21492) Update taiki-e/install-action action to v2.62.52 (#21493) Fix analyze graph tests on windows (#21481) `analyze`: Add option to skip over imports in `TYPE_CHECKING` blocks (#21472) [ty] Dataclasses: `__hash__` semantics and `unsafe_hash` (#21470) [ty] Dataclass transform: complete set of parameters (#21474) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the semantics of
__hash__for dataclasses and add support forunsafe_hashTest Plan
New Markdown tests.