[ty] Exit with 2 if there's any IO error
#21508
Merged
+54
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
micha/io-error-exit-code
branch
from
7fbc1c5 to
c8d3c5f
Compare
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Member
Author
|
Hmm, the mypy primer error is annoying The file is encoded in latin-1 and contains Umlaute I believe this is the desired behavior. But we now need a way to exclude this file 😟 |
MichaReiser
commented
Nov 18, 2025
sharkdp
reviewed
Nov 18, 2025
MichaReiser
force-pushed
the
micha/io-error-exit-code
branch
from
3c8a5c1 to
f3298fb
Compare
|
|
AlexWaygood
approved these changes
Nov 18, 2025
MichaReiser
force-pushed
the
micha/io-error-exit-code
branch
from
f3298fb to
e39cfc9
Compare
MichaReiser
force-pushed
the
micha/io-error-exit-code
branch
from
e39cfc9 to
43f165d
Compare
Contributor
|
Running ecosystem-analyzer, just to make sure that it also picks up the mypy_primer changes. |
|
| Project | Old Status | New Status | Old Return Code | New Return Code |
|---|---|---|---|---|
pywin32 |
success | abnormal exit | 1 |
2 |
dd-trace-py |
success | abnormal exit | 1 |
2 |
No diagnostic changes detected ✅
Full report with detailed diff (timing results)
Contributor
|
Ok, it does not automatically pick it up. I need to update the lockfile. |
dcreager
added a commit
that referenced
this pull request
Nov 19, 2025
* origin/main: [ty] Fix flaky tests on macos (#21524) [ty] Add tests for generic implicit type aliases (#21522) [ty] Semantic tokens: consistently add the `DEFINITION` modifier (#21521) Only render hyperlinks for terminals known to support them (#21519) [ty] Keep colorizing `mypy_primer` output (#21515) [ty] Exit with `2` if there's any IO error (#21508) [`ruff`] Fix false positive for complex conversion specifiers in `logging-eager-conversion` (`RUF065`) (#21464) [ty] tighten up handling of subscripts in type expressions (#21503)
dcreager
added a commit
that referenced
this pull request
Nov 19, 2025
* origin/main: [ty] Fix flaky tests on macos (#21524) [ty] Add tests for generic implicit type aliases (#21522) [ty] Semantic tokens: consistently add the `DEFINITION` modifier (#21521) Only render hyperlinks for terminals known to support them (#21519) [ty] Keep colorizing `mypy_primer` output (#21515) [ty] Exit with `2` if there's any IO error (#21508) [`ruff`] Fix false positive for complex conversion specifiers in `logging-eager-conversion` (`RUF065`) (#21464) [ty] tighten up handling of subscripts in type expressions (#21503)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#354
Exit with a code of
2if there's any IO error (because ty failed to read a file).Test Plan
Updated test