Exclude non-utf8 files when running ty #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
commented
Nov 18, 2025
| mypy_cmd="{mypy} {paths}", | ||
| pyright_cmd="{pyright} {paths}", | ||
| paths=["rotkehlchen", "tools/data_faker"], | ||
| paths=["rotkehlchen"], |
Contributor
Author
There was a problem hiding this comment.
The tools/data_faker directory no longer exists
MichaReiser
force-pushed
the
ty-exclude-non-utf-files
branch
from
dc18c5a to
99fe2fe
Compare
MichaReiser
commented
Nov 18, 2025
mypy_primer/projects.py
Outdated
| pyright_cmd="{pyright} {paths}", | ||
| paths=["pydantic"], | ||
| deps=["annotated-types", "pydantic-core", "typing-extensions", "typing-inspection"], | ||
| deps=[ |
Contributor
Author
There was a problem hiding this comment.
I don't mind reverting the formatting changes if keeping them single line is indeed preferred (it will require fighting my IDE but I can do it ;))
Collaborator
There was a problem hiding this comment.
I would like to see this change, but it was suggested elsewhere by @AlexWaygood that we might want to keep the existing format.
MichaReiser
force-pushed
the
ty-exclude-non-utf-files
branch
from
99fe2fe to
a042101
Compare
MichaReiser
force-pushed
the
ty-exclude-non-utf-files
branch
from
a042101 to
13f0fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to change ty to exit with an error code of 2 if there's an IO error.
This requires us to exclude non-utf files from checking
Test Plan
Passing CI on astral-sh/ruff#21508