Use trait for labels instead of TypeId
#5270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5263
Rust 1.72.0 changes
TypeId
from au64
to au128
. This breaks Ruffs release build because it increases the size ofFormatElement
.This PR removes the dependency on
TypeId
forLabelId
and instead introduces a new trait that downstream crates should implement on anenum
defining all labels for that project.This approach has two downsides:
LabelDefinition
. Mixing twoLabelDefinition
could result in two labels being equal that should not be equal. I added adebug assertion that compares the names of the labels to mitigate the risk.
Label
requires more boilerplate code than beforeOne main upside is that it allows a project to define all labels in a single place (and search for all label usages).
Test Plan
cargo test
cargo build -p ruff_python_formatter --release
on Rust 1.72.0