Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to parse version specifiers with trailing comma #1464

Closed
davidszotten opened this issue Feb 16, 2024 · 3 comments
Closed

fails to parse version specifiers with trailing comma #1464

davidszotten opened this issue Feb 16, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@davidszotten
Copy link
Contributor

davidszotten commented Feb 16, 2024

when installing from our devpi mirror, e.g. celery-5.2.2 fails to install. it looks like it's due to a trailing comma in the requires-python value. from reading the pep it's slightly unclear to me whether a trailing comma is allowed but uv is the first tool that's complained

i added a dbg!() because the error message didn't include the offending value (would be a nice addition i think)

   0.330188s  40ms  WARN uv_client::registry_client Skipping file for celery: Invalid 'requires-python' value
[crates/uv-client/src/registry_client.rs:632] err = VersionSpecifiersParseError(
    VersionSpecifiersParseError {
        inner: VersionSpecifiersParseErrorInner {
            err: VersionSpecifierParseError {
                kind: MissingOperator,
            },
            line: ">=3.7,",
            start: 6,
            end: 6,
        },
    },
)
@zanieb
Copy link
Member

zanieb commented Feb 16, 2024

Hey @davidszotten, which version are you using? I think we may have fixed this already.

xref #1361

@zanieb zanieb added the bug Something isn't working label Feb 16, 2024
@davidszotten
Copy link
Contributor Author

e6c4c77 (which includes that fix) still has the issue. will make a pr with a failing test (and a suggested fix)

@charliermarsh
Copy link
Member

Hopefully fixed by #1507?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants