Fix trailing commas on Requires-Python in HTML indexes
#1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We tend to fix this via our |
davidszotten
force-pushed
the
fix-trailing-commas
branch
from
9907868 to
10398d7
Compare
|
ah i see. how does this look? |
|
Ahh yes, this looks good. |
charliermarsh
changed the title
Requires-Python in HTML indexes
charliermarsh
changed the title
Requires-Python in HTML indexes Requires-Python in HTML indexes
davidszotten
commented
Feb 17, 2024
| @@ -137,7 +138,7 @@ impl SimpleHtml { | |||
| { | |||
| let requires_python = std::str::from_utf8(requires_python.as_bytes())?; | |||
| let requires_python = html_escape::decode_html_entities(requires_python); | |||
| Some(LenientVersionSpecifiers::from_str(&requires_python).map(Into::into)) | |||
| Some(LenientVersionSpecifiers::from_str(&requires_python).map(VersionSpecifiers::from)) | |||
There was a problem hiding this comment.
how come from is preferable? (to help me learn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
illustration and suggested fix for #1464