Discover and respect .python-version files in parent directories
#6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/version-file-discover
branch
from
916db9c
to
df3693e
Compare
zanieb
force-pushed
the
zb/python-find-pin
branch
3 times, most recently
from
c43d54f
to
1e375ef
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
2 times, most recently
from
1e02b28
to
2ca5bb4
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
from
2ca5bb4
to
6f07881
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
from
6f07881
to
3564e75
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
5 times, most recently
from
984c0dc
to
0c31b66
Compare
zanieb
commented
Oct 4, 2024
Comment on lines
1076
to
1081
| options | ||
| .stop_discovery_at | ||
| .and_then(Path::parent) | ||
| .map(|stop_discovery_at| stop_discovery_at != *path) | ||
| .unwrap_or(true) | ||
| }) |
There was a problem hiding this comment.
This code isn't used in production, but this updates the behavior in tandem with copying the implementation for PythonVersionFile::discover to solve a common footgun where you pass the project root as the place to stop discovery and discovery stopped before looking in that directory.
zanieb
force-pushed
the
zb/version-file-discover
branch
from
0c31b66
to
932048f
Compare
zanieb
commented
Oct 4, 2024
Comment on lines
376
to
380
| pub(crate) async fn from_request( | ||
| python_request: Option<PythonRequest>, | ||
| workspace: &Workspace, | ||
| workspace: Option<&Workspace>, | ||
| project_dir: &Path, | ||
| ) -> Result<Self, ProjectError> { |
There was a problem hiding this comment.
Instead of making workspace optional here, I might introduce a new abstraction which is used by WorkspacePython? It's doing a bit more work than it ought to as-is, but it's not clear another abstraction is worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #6369 for test coverage.
Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372).
There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like
uv build— I'm not sure how I'm going to handle that yet as it needs a separate root directory.