Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify types for partitioning columns. #171

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Specify types for partitioning columns. #171

merged 3 commits into from
Nov 29, 2023

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Nov 28, 2023

Change Description

One solution for issue #161 - sets the types of partitioning columns to:

  • Norder: uint8
  • Dir/Npix: uint64

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f44b40) 100.00% compared to head (2968ecf) 100.00%.
Report is 4 commits behind head on main.

❗ Current head 2968ecf differs from pull request most recent head 48c5dae. Consider uploading reports for the commit 48c5dae to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1158      1160    +2     
=========================================
+ Hits          1158      1160    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@delucchi-cmu delucchi-cmu merged commit 924a69f into main Nov 29, 2023
10 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/161/types branch November 29, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants