Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate polygon search to use mocpy utilities #415

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

camposandro
Copy link
Contributor

Migrate polygon pixel filtering to use MOC.from_polygon_skycoord instead of healpy.query_polygon. This change adds some more polygon validation (borrowed from HEALpy) to make sure the polygon is convex, which is a requirement for lsst.sphgeom. Closes #402.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (17ec4ac) to head (98bc347).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   92.99%   93.02%   +0.03%     
==========================================
  Files          49       47       -2     
  Lines        2127     2122       -5     
==========================================
- Hits         1978     1974       -4     
+ Misses        149      148       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camposandro camposandro marked this pull request as ready for review November 8, 2024 19:00
Copy link

github-actions bot commented Nov 8, 2024

Before [17ec4ac] <v0.4.3> After [d8baa5f] Ratio Benchmark (Parameter)
13.8±0.9ms 15.7±0.4ms ~1.14 benchmarks.Suite.time_inner_pixel_alignment
110±1ms 110±0.8ms 1.01 benchmarks.Suite.time_paths_creation
23.1±0.3ms 23.1±0.3ms 1.00 benchmarks.MetadataSuite.time_load_partition_info_order6
93.7±0.4ms 93.4±0.3ms 1.00 benchmarks.MetadataSuite.time_load_partition_join_info
382±4ms 381±2ms 1.00 benchmarks.Suite.time_outer_pixel_alignment
46.6±0.5ms 46.6±0.4ms 1.00 benchmarks.Suite.time_pixel_tree_creation
125±1ms 125±0.7ms 1.00 benchmarks.time_test_alignment_even_sky
1.03±0.03ms 1.02±0.03ms 1.00 benchmarks.time_test_cone_filter_multiple_order
94.4±0.6ms 93.0±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7

Click here to view all benchmarks.

@camposandro camposandro merged commit e47eab1 into main Nov 14, 2024
11 checks passed
@camposandro camposandro deleted the sandro/refactor-search branch November 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate polygon filter to use cds-healpix utilities
2 participants