Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HATS filter_by_* methods for spatial filtering #497

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

camposandro
Copy link
Collaborator

Refactor spatial searches to use the filter_by_* methods of the HATS structure. Remove references to SphericalCoordinates/CartesianCoordinates that were suppressed in astronomy-commons/hats#415.

@camposandro camposandro self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Before [e86782b] After [0a910f9] Ratio Benchmark (Parameter)
failed 15.2±0.1ms n/a benchmarks.time_box_filter_on_partition
failed 14.4±0.04s n/a benchmarks.time_create_large_catalog
failed 2.16±0.02s n/a benchmarks.time_create_midsize_catalog
failed 99.6±3ms n/a benchmarks.time_kdtree_crossmatch
failed failed n/a benchmarks.time_polygon_search

Click here to view all benchmarks.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.66%. Comparing base (6129472) to head (9907346).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/core/search/abstract_search.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   97.67%   97.66%   -0.02%     
==========================================
  Files          39       39              
  Lines        1550     1540      -10     
==========================================
- Hits         1514     1504      -10     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camposandro camposandro marked this pull request as ready for review November 8, 2024 19:48
Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig the simplification here!

@camposandro camposandro merged commit 76a8ab1 into main Nov 14, 2024
9 of 11 checks passed
@camposandro camposandro deleted the sandro/refactor-search branch November 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants