fix: Validate user input forge#199

Protect in one place for out of range.
astubbs · Oct 19, 2021 · 595d32a · 595d32a
1 parent 14e0f6b
commit 595d32a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 14 deletions.
diff --git a/api/src/main/java/org/jboss/forge/roaster/ParserException.java b/api/src/main/java/org/jboss/forge/roaster/ParserException.java
@@ -79,7 +79,7 @@ public ParserException(final String message, final Throwable cause)
     */
    public ParserException(String message, List<Problem> problems)
    {
-      super(message);
+      super(message + "\n" + problems.toString());
       this.problems = problems;
    }
 

diff --git a/impl/src/main/java/org/jboss/forge/roaster/model/impl/MethodImpl.java b/impl/src/main/java/org/jboss/forge/roaster/model/impl/MethodImpl.java
@@ -130,10 +130,25 @@ public MethodImpl(final O parent, final String method)
       init(parent);
 
       String stub = "public class Stub { " + method + " }";
+      List<MethodSource<JavaClassSource>> methods = getMethodSources(stub);
+      MethodSource<JavaClassSource> javaClassSourceMethodSource = methods.get(0);
+      MethodDeclaration newMethod = (MethodDeclaration) javaClassSourceMethodSource.getInternal();
+      this.method = (MethodDeclaration) ASTNode.copySubtree(cu.getAST(), newMethod);
+   }
+
+   private List<MethodSource<JavaClassSource>> getMethodSources(final String stub)
+   {
+      List<Problem> problems = Roaster.validateSnippet(stub);
+      if (!problems.isEmpty())
+      {
+         throw new IllegalArgumentException("Invalid method code. " + problems);
+      }
+
       JavaClassSource temp = (JavaClassSource) Roaster.parse(stub);
       List<MethodSource<JavaClassSource>> methods = temp.getMethods();
-      MethodDeclaration newMethod = (MethodDeclaration) methods.get(0).getInternal();
-      this.method = (MethodDeclaration) ASTNode.copySubtree(cu.getAST(), newMethod);
+      if (methods.isEmpty())
+         throw new IllegalArgumentException("No methods found - check your method syntax");
+      return methods;
    }
 
    @Override
@@ -142,7 +157,7 @@ public String toSignature()
       StringBuilder signature = new StringBuilder();
       signature.append(Visibility.PACKAGE_PRIVATE == this.getVisibility() ? ""
                : this.getVisibility()
-                        .scope());
+               .scope());
       signature.append(" ");
       signature.append(this.getName()).append("(");
       List<ParameterSource<O>> parameters = this.getParameters();
@@ -266,11 +281,10 @@ public MethodSource<O> setBody(final String body)
          List<Problem> problems = Roaster.validateSnippet(body);
          if (problems.size() > 0)
          {
-            throw new ParserException(problems);
+            throw new ParserException("Parse error in:\n" + body, problems);
          }
          String stub = "public class Stub { public void method() {" + body + "} }";
-         JavaClassSource temp = (JavaClassSource) Roaster.parse(stub);
-         List<MethodSource<JavaClassSource>> methods = temp.getMethods();
+         List<MethodSource<JavaClassSource>> methods = getMethodSources(stub);
          Block block = ((MethodDeclaration) methods.get(0).getInternal()).getBody();
          block = (Block) ASTNode.copySubtree(method.getAST(), block);
          method.setBody(block);
@@ -336,8 +350,7 @@ public MethodSource<O> setReturnType(final String typeName)
       String typeToUse = Types.toResolvedType(typeName, getOrigin());
 
       String stub = "public class Stub { public " + typeToUse + " method() {} }";
-      JavaClassSource temp = (JavaClassSource) Roaster.parse(stub);
-      List<MethodSource<JavaClassSource>> methods = temp.getMethods();
+      List<MethodSource<JavaClassSource>> methods = getMethodSources(stub);
       org.eclipse.jdt.core.dom.Type returnType = ((MethodDeclaration) methods.get(0).getInternal()).getReturnType2();
 
       returnType = (org.eclipse.jdt.core.dom.Type) ASTNode.copySubtree(method.getAST(), returnType);
@@ -494,8 +507,7 @@ public MethodSource<O> setName(final String name)
    public MethodSource<O> setParameters(final String parameters)
    {
       String stub = "public class Stub { public void method( " + parameters + " ) {} }";
-      JavaClassSource temp = (JavaClassSource) Roaster.parse(stub);
-      List<MethodSource<JavaClassSource>> methods = temp.getMethods();
+      List<MethodSource<JavaClassSource>> methods = getMethodSources(stub);
       List<VariableDeclaration> astParameters = ((MethodDeclaration) methods.get(0).getInternal()).parameters();
 
       method.parameters().clear();
@@ -791,7 +803,7 @@ public MethodSource<O> removeTypeVariable(String name)
    {
       @SuppressWarnings("unchecked")
       List<TypeParameter> typeParameters = method.typeParameters();
-      for (Iterator<TypeParameter> iter = typeParameters.iterator(); iter.hasNext();)
+      for (Iterator<TypeParameter> iter = typeParameters.iterator(); iter.hasNext(); )
       {
          if (Objects.equals(name, iter.next().getName().getIdentifier()))
          {
@@ -834,8 +846,7 @@ public ParameterSource<O> addParameter(String type, String name)
       }
 
       String stub = "public class Stub { public void method( " + resolvedType + " " + name + " ) {} }";
-      JavaClassSource temp = (JavaClassSource) Roaster.parse(stub);
-      List<MethodSource<JavaClassSource>> methods = temp.getMethods();
+      List<MethodSource<JavaClassSource>> methods = getMethodSources(stub);
       List<VariableDeclaration> astParameters = ((MethodDeclaration) methods.get(0).getInternal()).parameters();
 
       ParameterSource<O> param = null;