Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All user code input should be validated #199

Open
astubbs opened this issue Jul 29, 2021 · 0 comments · May be fixed by #200
Open

All user code input should be validated #199

astubbs opened this issue Jul 29, 2021 · 0 comments · May be fixed by #200

Comments

@astubbs
Copy link

astubbs commented Jul 29, 2021

You should not be able to pass in invalid code and get obscure errors like "index out of range" exceptions. I found one place for this but the code should be audited for it everywhere. Better to run slower and have excellent errors.
astubbs added a commit to astubbs/roaster that referenced this issue Jul 29, 2021
@astubbs
fix: All user code input should be validated forge#199
a08a8ba 
You should not be able to pass in invalid code and get obscure errors like "index out of range" exceptions. I found one place for this but the code should be audited for it everywhere. Better to run slower and have excellent errors.
@astubbs astubbs linked a pull request Jul 29, 2021 that will close this issue
Open
astubbs added a commit to astubbs/roaster that referenced this issue Oct 19, 2021
@astubbs
fix: Validate user input forge#199
595d32a 
Protect in one place for out of range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: All user code input should be validated #199 astubbs/roaster
1 participant
@astubbs