Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search within a collection #55

Closed
elizoller opened this issue Nov 27, 2019 · 19 comments
Closed

Search within a collection #55

elizoller opened this issue Nov 27, 2019 · 19 comments
Assignees
Labels

Comments

@elizoller
Copy link
Contributor

Islandora/documentation#1275

@elizoller
Copy link
Contributor Author

@elizoller elizoller added this to the Search, Auth, Licensing milestone Dec 9, 2019
elizoller added a commit that referenced this issue Dec 12, 2019
…ion based views to be based on content type instead of on the repo item with a label - part of #51 and #55
@elizoller
Copy link
Contributor Author

This has been configured as two different blocks - one that does deep search and one that just goes one level deep. https://github.com/asulibraries/islandora-repo/blob/develop/config/sync/views.view.search_within_collection.yml

@wgilling
Copy link
Contributor

For the MVP, will this only require the browse functionality or also a "Collection View" page as we saw with the UNT site -- compare:
View: https://digital.library.unt.edu/explore/collections/UNTPC/
Browse: https://digital.library.unt.edu/explore/collections/UNTPC/browse/

I'd love to ultimately have both but am not trying to make more than the MVP for that goal -- and could see a "Collection View" page as a near-future enhancement.

@wgilling
Copy link
Contributor

wgilling commented Mar 19, 2020

The blocks referenced by @elizoller are not really part of the commits that I made in the "search_collection" branch (while they remain as blocks "Deep Search within collection" and "Search within collection" as well as an exposed block "Exposed form: search-page_1" from that view's page that can still be played with). They display the contents of the search within the block itself.

The approach taken by the latest commit is to have a page (view) "Solr search content (Index Default Solr content index)" that has an exposed field in the sidebar (block) "Exposed form: solr_search_content-page_2".

@wgilling
Copy link
Contributor

Future concerns are

  1. subsequent searches should incorporate all previous searching / selected facets
  2. how to deal with breadcrumbs for existing filter(s) and selected facets

@elizoller
Copy link
Contributor Author

just to clarify - we're going to extend/modify the solr search content view provided by islandora defaults instead of rolling our own? is it worth separating the search within collection from the regular search view, or its similar enough to be ok as part of the same view?

if we're going to use all the same view, i'll go ahead and strip out all the previous views and associated blocks and facets that i'd created in favor of this methodology

@wgilling
Copy link
Contributor

wgilling commented Mar 19, 2020

sounds good -- the global site search is still part of that view but it is a different page... if you feel that it is best to separate it, I could do that. For that reason, I thought it might be better to have the various search views all controlled under one view (for the parts that apply to "all displays (except overridden)" vs. "this {page_name} display (override)"). Lemme know if you prefer to have them separate.

@elizoller
Copy link
Contributor Author

i think you're right - that way if we configure stuff like sorting/pagination/etc, it could apply as defaults to all of the pages 👍 so i should review/merge the search_collection branch?

@wgilling
Copy link
Contributor

I think so ... I changed the view path to solr-search-collection/{nid} and reference the 2nd query parameter. I only changed one thing in the context and something minor in the view (I think) as well as how the hook rewrote the path with a str_replace - now that I think about it, the regular expression may be better since there is potential for the $current_path could be a node/* or a solr-search-collection/*.

I feel that it needs a bit of cleanup and a minor adjustment to handle the 2nd path parameter when it comes from either node/{nid} or is a subsequent search coming from solr-search-collection/{nid}.

Another thought that I just had is that when a user clicks on a collection facet for any global search, it makes me think that we may want to have a "Search in Creator" or "Search in Subject" view page... but that's a topic for another repo-dev meeting.

@elizoller
Copy link
Contributor Author

what are your thoughts on changing the "solr-search" paradigm to just "search" - maybe it's just a pet peeve but i don't really want a user to see a url with the word solr in it if we can avoid it

@wgilling
Copy link
Contributor

I COMPLETELY approve of getting the "solr-" out of the path and subsequently block name. I'll update that as well and then push this before the end of the day.

@elizoller
Copy link
Contributor Author

awesome! thanks

wgilling added a commit that referenced this issue May 22, 2020
wgilling added a commit that referenced this issue May 26, 2020
…updated to use islandora_entity_bundle, and auto-generated ASU features bundle added #55
wgilling added a commit that referenced this issue Jun 4, 2020
… javascript. also cleaned up white space errors #55
wgilling added a commit that referenced this issue Jun 8, 2020
wgilling added a commit that referenced this issue Jun 8, 2020
…ked more configuration settings, removed tab for Citations page and Full Metadata tab still displaying. #55
wgilling added a commit that referenced this issue Jun 12, 2020
…n_view and links in the Explore this Item block based on the item's islandora_object.model value #55
@wgilling wgilling self-assigned this Aug 24, 2020
@wgilling
Copy link
Contributor

need to test this feature against the use case

@wgilling
Copy link
Contributor

The Members view is only bringing in items that have the "Primary Member Of" relationship (field_member_of) and would not display any items when the item is also in a different collection *(which case it would be related via the "field_additional_memberships").

The view could be redone as a "Solr Search Results" view and make use of the "Ancestors" calculated field.

@elizoller
Copy link
Contributor Author

isn't that what the "Search within collection" view is already doing as a page rather than a block?

@elizoller
Copy link
Contributor Author

and in fact the members/children block may not even be relevant to our mockups

@elizoller
Copy link
Contributor Author

unless you're referring to the "Latest Additions" block?

@wgilling
Copy link
Contributor

isn't that what the "Search within collection" view is already doing as a page rather than a block?

Yes, this view is a "Solr Search Results" view. And if the "Recent Additions" has a "Vuew more results" link, it would be able to go to this page, so a new view may not be needed.

wgilling added a commit that referenced this issue Sep 3, 2020
… renamed the asu_collection_extras in the info file for #111 and #55
elizoller added a commit that referenced this issue Sep 3, 2020
@elizoller
Copy link
Contributor Author

closed with #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants