Clean up the fs module and a few other places #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2019
Closed
|
Let's merge this or else we might have merge conflicts soon bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 16, 2019
190: Clean up the fs module and a few other places r=stjepang a=stjepang Just a cleanup for various pieces of documentation, mainly around the `lib.rs` docs, the prelude, and the `fs` module. Some small bugs are also fixed along the way. This PR is the first one in a series of review PRs that I will be submitting before the upcoming 1.0 release. 200: expose IoSlice, IoSliceMut r=stjepang a=yoshuawuyts Exposes `io::IoSlice` and `io::IoSliceMut`. Given we're returning these from `read_vectored` and `write_vectored` it might make sense to just include them as part of our re-exports. Thanks! Ref #131. Co-authored-by: Stjepan Glavina <stjepang@gmail.com> Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Build succeeded
|
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cleanup for various pieces of documentation, mainly around the
lib.rsdocs, the prelude, and thefsmodule. Some small bugs are also fixed along the way.This PR is the first one in a series of review PRs that I will be submitting before the upcoming 1.0 release.