Skip to content

Document feature flags in readme #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2019
Merged

Document feature flags in readme #202

merged 5 commits into from
Sep 16, 2019

Conversation

@yoshuawuyts
Copy link
Contributor

@yoshuawuyts yoshuawuyts commented Sep 16, 2019

Follow up to #190, this documents our feature flags in our readme. Thanks!

@yoshuawuyts
document feature flags
dc66478 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts added the documentation Improvements or additions to documentation label Sep 16, 2019
@yoshuawuyts
document feature flags
6e5f29f 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
ghost
ghost approved these changes Sep 16, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

yoshuawuyts and others added 3 commits September 16, 2019 15:58
@yoshuawuyts
Update README.md
e6fe8da 
Co-Authored-By: Stjepan Glavina <stjepang@gmail.com>
@yoshuawuyts
Update README.md
7827410
@yoshuawuyts
Update README.md
8058d63 
Co-Authored-By: Stjepan Glavina <stjepang@gmail.com>
@yoshuawuyts
Copy link
Contributor Author

yoshuawuyts commented Sep 16, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 16, 2019
@bors @yoshuawuyts
Merge #202
dd92d8d 
202: Document feature flags in readme r=yoshuawuyts a=yoshuawuyts

Follow up to #190, this documents our feature flags in our readme. Thanks!

Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Co-authored-by: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 16, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 8058d63 into master Sep 16, 2019
@ghost ghost deleted the docs-features branch September 16, 2019 14:56
@yoshuawuyts yoshuawuyts mentioned this pull request Sep 17, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoshuawuyts