Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update smol dependencies #866

Merged
merged 3 commits into from
Sep 14, 2020
Merged

update smol dependencies #866

merged 3 commits into from
Sep 14, 2020

Conversation

Keruspe
Copy link
Member

@Keruspe Keruspe commented Aug 27, 2020

Updates all of the subcomponents of smol that we're now using to their latest versions

cc @stjepang

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@ghost
Copy link

ghost commented Aug 31, 2020

The codebase has a dozen or so instances of this line of code:

once_cell::sync::Lazy::force(&crate::rt::RUNTIME);

With latest version of smol, it is not needed anywhere except in src/task/builder.rs. Can you delete it everywhere except in the task module?

This way, if libraries like async-h1 depend on async-std and only use its timers or networking primitives, the executor threadpool will not even be initialized. The only thread that gets started is the "async-io" thread.

I think this will make async-std feel more lightweight because the executor threadpool is then only started by std::task::spawn().

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Keruspe
Copy link
Member Author

Keruspe commented Aug 31, 2020

Nice catch indeed, fixed

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Keruspe
Copy link
Member Author

Keruspe commented Sep 7, 2020

Updated to newly released 1.0 versions

Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dignifiedquire dignifiedquire merged commit f731959 into async-rs:master Sep 14, 2020
@Keruspe
Copy link
Member Author

Keruspe commented Sep 14, 2020

@stjepang async-executor 1.1.0 fails o android (CI now failing after this has been merged)

error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
  --> /cargo/registry/src/github.com-1ecc6299db9ec823/async-executor-1.1.0/src/lib.rs:29:47
   |
29 | use std::sync::atomic::{AtomicBool, Ordering, AtomicU64, AtomicUsize};
   |                                               ^^^^^^^^^
   |                                               |
   |                                               no `AtomicU64` in `sync::atomic`
   |                                               help: a similar name exists in the module: `AtomicU8`

@ghost
Copy link

ghost commented Sep 14, 2020

Should be fixed with async-executor v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants