-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update smol dependencies #866
Conversation
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
The codebase has a dozen or so instances of this line of code: once_cell::sync::Lazy::force(&crate::rt::RUNTIME); With latest version of smol, it is not needed anywhere except in This way, if libraries like I think this will make async-std feel more lightweight because the executor threadpool is then only started by |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Nice catch indeed, fixed |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Updated to newly released 1.0 versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@stjepang async-executor 1.1.0 fails o android (CI now failing after this has been merged)
|
Should be fixed with async-executor v1.1.1 |
Updates all of the subcomponents of smol that we're now using to their latest versions
cc @stjepang