-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move executor to async-global-executo #867
Conversation
Hi, thanks for this PR! I def see how sharing the global executor between projects could be useful. But in order to accept this PR I'd like to see:
I hope that makes sense. Thanks heaps! |
Done and Done. I'm fine with moving it to async-rs too if you see fit |
a158cdc
to
ebd0050
Compare
Rebased on top of the 1.0 bumps |
Thanks. I was out for the last two weeks, will be back in the next days and take a look at this. |
ebd0050
to
03cd32e
Compare
Rebased |
CI failure should now be fixed with async-executor 1.1.1 |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
98f95f9
to
d8b0786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, given that this is pretty much still the same code, but in a different place for now. I do like having it extracted as its own crate.
Thanks
Based on #866
This uses async-executor under the hood and is highly inspired by both smol and the async-executor implementation inside of async-std.
Pros:
Cons: