Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move executor to async-global-executo #867

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

Keruspe
Copy link
Member

@Keruspe Keruspe commented Aug 28, 2020

Based on #866

This uses async-executor under the hood and is highly inspired by both smol and the async-executor implementation inside of async-std.

Pros:

  • less code inside async-std, simpler integration
  • shares the same executors with any other users of async-global-executor
  • allows spawning local tasks on all of the global executor threads

Cons:

  • adds one more extra dependency
  • ???

@yoshuawuyts
Copy link
Contributor

Hi, thanks for this PR!

I def see how sharing the global executor between projects could be useful. But in order to accept this PR I'd like to see:

  1. async-global-executor dual licensed as MIT / Apache-2.0. If ever need to migrate away from async-global-executor we shouldn't need to worry about licensing questions.
  2. Granting commit/publish access to @dignifiedquire, @stjepang or myself. Or moving the project to the async-rs org. That way if something ever needs fixing that is time-critical and for some reason we can't reach you, we're still able to move ahead.

I hope that makes sense. Thanks heaps!

@Keruspe
Copy link
Member Author

Keruspe commented Aug 28, 2020

Done and Done.

I'm fine with moving it to async-rs too if you see fit

@Keruspe
Copy link
Member Author

Keruspe commented Sep 7, 2020

Rebased on top of the 1.0 bumps

@dignifiedquire
Copy link
Member

Thanks. I was out for the last two weeks, will be back in the next days and take a look at this.

@Keruspe
Copy link
Member Author

Keruspe commented Sep 14, 2020

Rebased

@Keruspe
Copy link
Member Author

Keruspe commented Sep 14, 2020

CI failure should now be fixed with async-executor 1.1.1

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, given that this is pretty much still the same code, but in a different place for now. I do like having it extracted as its own crate.
Thanks

@dignifiedquire dignifiedquire changed the title RFC: switch to async-global-executor feat: move executor to async-global-executo Sep 15, 2020
@dignifiedquire dignifiedquire merged commit 352c54b into async-rs:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants