-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: publish playground from next branch #352
ci: publish playground from next branch #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct me if I'm wrong, but this PR introduces features and fixes for 3 totally unrelated topics, right?
- update of openapi-sampler should be a separate PR to master and merged as
feat:
with a proper description of what else is added with their first major version of openapi-sampler, as it is purely not only because oftime
format - fix of errors should also go to master
above can be then pulled into next
and last but not least is a PR to next
with circular refs support for items as this is a part of the release candidate for major version.
@derberg Thanks for the review!
Ok, I will create a PR for that. There is also supporting for
It cannot be done, and then pulled, because code for displaying errors is different in TBH I don't think so that we should split those changes to 3 separates PRs, then it's is an art for art, but ok, I will create it. |
In addition, errors from parser has been displaying on the master for a long time, I just want to close one issue, because I fixed some styles displaying errors -> little change https://github.com/asyncapi/asyncapi-react/pull/352/files#diff-18b2a4882a0019cfc814b13ccea23aeaf24e1835040ea9912df58f980043aa0cR19 so I don't think so that we should split this change to separate PR. |
@magicmatatjahu not really art for art, it is just cleaner and by pushing openapi-sampler to master you make the feature available to others long weeks before major version of the component is available, it is worth it. As for the errors, I agree that if it is going to be to complex later to pull it into next, then let us not put it into master |
About |
if you want to have a quick review, then it is not art 🤷🏼 |
bbd6842
to
9040fe5
Compare
Kudos, SonarCloud Quality Gate passed! |
@derberg Thanks a lot! |
🎉 This PR is included in version 1.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
next
branch - update appropriate workflow for thatErrors:
Related issue(s)
Part of #300