fix: rendering the circular items #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
bug
derberg
reviewed
May 26, 2021
|
@derberg Ok I added comment :) /**
* checking uid for circular items
* after fixing https://github.com/asyncapi/parser-js/issues/293 statement should be removed
* `x-parser-circular` extension is added to every schema which has circular `items` field,
* so we must check that `items` is schema (not array of schemas) and infer UID of schema to display which schema is circular (by the name of schema)
*/ |
derberg
approved these changes
May 26, 2021
magicmatatjahu
force-pushed
the
next-branches/circular-items
branch
from
89b1421
to
8ef4ac9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 1.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Rendering the circular items.
Related issue(s)
Fixes #351