Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server do not work out of the box with new @asyncapi/specs 4.0 #188

Closed
derberg opened this issue Oct 24, 2022 · 4 comments · Fixed by #202
Closed

Server do not work out of the box with new @asyncapi/specs 4.0 #188

derberg opened this issue Oct 24, 2022 · 4 comments · Fixed by #202
Assignees
@vinibiavatti1
Labels
bug Something isn't working released

Comments

@derberg
Copy link
Member

derberg commented Oct 24, 2022

Describe the bug

Tests are failing with new version -> https://github.com/asyncapi/server-api/actions/runs/3298011137/jobs/5439567189
So the bump cannot be performed -> #184

How to Reproduce

Get locally PR with bump gh pr checkout 184 and run tests

Expected behavior

It should work out of the box, as in 4.0 what we did was that we just removed old specs from the package, prior 2.0
@derberg derberg added the bug Something isn't working label Oct 24, 2022
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@vinibiavatti1
Copy link
Contributor

I would like to work on this issue to contribute to the project. Can you assign it to me?

@BOLT04
Copy link
Member

BOLT04 commented Nov 18, 2022

Sure thing, thanks @vinibiavatti1 👍

vinibiavatti1 added a commit to vinibiavatti1/server-api that referenced this issue Nov 18, 2022
@vinibiavatti1
fix: update @async/specs to version 4.0.0 and fix tests (asyncapi#188)
e76446f
@vinibiavatti1 vinibiavatti1 mentioned this issue Nov 18, 2022
Merged
vinibiavatti1 added a commit to vinibiavatti1/server-api that referenced this issue Dec 13, 2022
@vinibiavatti1
build: Updates package-lock asyncapi#188
591a839
asyncapi-bot pushed a commit that referenced this issue Dec 13, 2022
@vinibiavatti1
fix: update @async/specs to version 4.0.0 and fix tests (#188) (#202)
4ba5030
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.11.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinibiavatti1 vinibiavatti1

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update @async/specs to version 4.0.0 and fix tests (#188) vinibiavatti1/server-api
4 participants
@derberg @BOLT04 @vinibiavatti1 @asyncapi-bot