-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update @async/specs to version 4.0.0 and fix tests (#188) #202
fix: update @async/specs to version 4.0.0 and fix tests (#188) #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
hi @vinibiavatti1, thanks for the contribution 😃. It seems the docker build is failing, can you try and check what is the problem locally? |
@vinibiavatti1 as @BOLT04 wrote, please check if locally it works, and if not, please update typescript to the latest version (in package.json) and check again. In other projects new dependency works. |
Hi @BOLT04 and @magicmatatjahu |
@vinibiavatti1 You can update dep to the |
@vinibiavatti1 the docker build is passing now 🎉, we just need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :) @BOLT04 Do you wanna add something?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
package-lock updated and branch merged with master ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/rtm |
🎉 This PR is included in version 0.11.16 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
@asyncapi/specs
to version4.0.0
openapi.yaml
unsupported versionsconvert.controller.test.ts
andconvert.service.test.ts
to work on4.0.0
versionconvert.service.test.ts
to cast specs versions to SpecsEnumRelated issue(s)
Resolves #188