Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @async/specs to version 4.0.0 and fix tests (#188) #202

Merged

Conversation

vinibiavatti1
Copy link
Contributor

Description

  • Changed @asyncapi/specs to version 4.0.0
  • Removed openapi.yaml unsupported versions
  • Fixed convert.controller.test.ts and convert.service.test.ts to work on 4.0.0 version
  • Fixed convert.service.test.ts to cast specs versions to SpecsEnum

Related issue(s)

Resolves #188

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@BOLT04
Copy link
Member

BOLT04 commented Nov 20, 2022

hi @vinibiavatti1, thanks for the contribution 😃. It seems the docker build is failing, can you try and check what is the problem locally?
It seems it's error TS2666: Exports and export assignments are not permitted in module augmentations.

@magicmatatjahu
Copy link
Member

@vinibiavatti1 as @BOLT04 wrote, please check if locally it works, and if not, please update typescript to the latest version (in package.json) and check again.

In other projects new dependency works.

@vinibiavatti1
Copy link
Contributor Author

Hi @BOLT04 and @magicmatatjahu
I tested locally and had the same error. After search a bit, I noticed that the problem is with the index.d.ts file, that has a wrong definition for the target file in which is a commonjs file type. I oppened a PR to the spec project with the fix. Here is the link:
asyncapi/spec-json-schemas#288

@magicmatatjahu
Copy link
Member

@vinibiavatti1 You can update dep to the 4.0.1 :)

@BOLT04
Copy link
Member

BOLT04 commented Nov 24, 2022

@vinibiavatti1 the docker build is passing now 🎉, we just need to update package-lock.json and we can merge 👍

magicmatatjahu
magicmatatjahu previously approved these changes Dec 13, 2022
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) @BOLT04 Do you wanna add something?

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinibiavatti1
Copy link
Contributor Author

package-lock updated and branch merged with master ;)

Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Noice Key and Peele

@BOLT04
Copy link
Member

BOLT04 commented Dec 13, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 4ba5030 into asyncapi:master Dec 13, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.11.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server do not work out of the box with new @asyncapi/specs 4.0
4 participants