Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generated index.d.ts file using tsc command (#287) #288

Merged

Conversation

vinibiavatti1
Copy link
Contributor

Description
Used tsc command to recreate index.d.ts (definiton file) for index.js since it could not be compiled. The reason is that the index.js file is a commonjs file, and the definition file does not allow module augmentation with exports when commonjs is used to the main module.

Related issue(s)
Fixes #287

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Nov 24, 2022

@magicmatatjahu can you 🙏🏼 have a look

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested new typings in the Studio as dependency and it works. Thanks for contribution!

@derberg You can accept and merge.

@derberg
Copy link
Member

derberg commented Nov 24, 2022

@magicmatatjahu thanks mate 🙏🏼
@vinibiavatti1 thanks for contribution

/rtm

@asyncapi-bot asyncapi-bot merged commit c1a6f3c into asyncapi:master Nov 24, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build index.d.ts file due to an invalid export syntax
4 participants