-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generated index.d.ts file using tsc command (#287) #288
fix: generated index.d.ts file using tsc command (#287) #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@magicmatatjahu can you 🙏🏼 have a look |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested new typings in the Studio as dependency and it works. Thanks for contribution!
@derberg You can accept and merge.
@magicmatatjahu thanks mate 🙏🏼 /rtm |
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Used tsc command to recreate index.d.ts (definiton file) for index.js since it could not be compiled. The reason is that the index.js file is a commonjs file, and the definition file does not allow module augmentation with exports when commonjs is used to the main module.
Related issue(s)
Fixes #287