-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add schema for 2.6.0 and pulsar binding to ObjectBinding #295
Conversation
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
…lows/scripts/mailchimp (asyncapi#282)
…capi#288) Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
added pulsar binding, and googlepubsub, which appears to have gone missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@philCryoport the release will happen this month. We have 4 release months: January, April, June, and September. Check out this document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM but this PR should target |
Thank you @fmvilas ! I didn't know to go look for that file. |
I had to look up "LGTM". For a second I was wondering if it was some equivalent to "Release the Kracken!" |
The base branch was changed.
because of #302 we have conflicts here |
Kudos, SonarCloud Quality Gate passed! |
conflict solved. It was related to a fact that in 2.5 apparently we did not add |
/rtm |
🎉 This PR is included in version 3.3.0-next-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-next-major-spec.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
Pulsar binding PR
Add pulsar to specification PR