Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema for 2.6.0 and pulsar binding to ObjectBinding #295

Merged
merged 31 commits into from
Jan 31, 2023

Conversation

VisualBean
Copy link
Collaborator

@VisualBean VisualBean commented Dec 9, 2022

Description

  • Added definitions for 2.6.0 in preparation for 2.6.0
  • Built schema 2.6.0 in preparation for 2.6.0
  • Added googlepubsub and pulsar to the BindingObject definition

Related issue(s)
Pulsar binding PR
Add pulsar to specification PR

asyncapi-bot and others added 23 commits September 29, 2022 09:05
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
…capi#288)

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
added pulsar binding, and googlepubsub, which appears to have gone missing.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@fmvilas
Copy link
Member

fmvilas commented Jan 11, 2023

@philCryoport the release will happen this month. We have 4 release months: January, April, June, and September. Check out this document.

KhudaDad414
KhudaDad414 previously approved these changes Jan 11, 2023
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derberg
Copy link
Member

derberg commented Jan 11, 2023

LGTM but this PR should target next-spec branch, not master as it is spec related release

@philCryoport
Copy link

@philCryoport the release will happen this month. We have 4 release months: January, April, June, and September. Check out this document.

Thank you @fmvilas ! I didn't know to go look for that file.

@philCryoport
Copy link

I had to look up "LGTM". For a second I was wondering if it was some equivalent to "Release the Kracken!"

@derberg derberg changed the title chore: add schema for 2.6.0 and pulsar binding to ObjectBinding feat: add schema for 2.6.0 and pulsar binding to ObjectBinding Jan 16, 2023
@VisualBean VisualBean changed the base branch from master to next-spec January 18, 2023 12:18
@VisualBean VisualBean dismissed stale reviews from KhudaDad414 and fmvilas January 18, 2023 12:18

The base branch was changed.

@derberg
Copy link
Member

derberg commented Jan 30, 2023

because of #302 we have conflicts here

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented Jan 30, 2023

conflict solved. It was related to a fact that in 2.5 apparently we did not add googlepubsub binding to proper json schema, but just to generated one #253 and the other PR from @AceTheCreator to next-spec fixed it and added googlepubsub to the list, thus conflict. I hope that makes sense 😅

@derberg
Copy link
Member

derberg commented Jan 31, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 9e1a24c into asyncapi:next-spec Jan 31, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.3.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.