Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add studio tour for first time user #1120

Merged
merged 25 commits into from
Sep 23, 2024
Merged

Conversation

aialok
Copy link
Contributor

@aialok aialok commented Jun 27, 2024

Description

  • This PR will introduce a tour for first-time users.
  • There are a total of ten steps explaining each component of the studio.

Related issue(s)

Here's is snapshot :

Screencast.from.2024-06-27.22-55-36.webm

Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: c1f37c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit c1f37c7
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/66ef0f89a4da0c000867b7bd
😎 Deploy Preview https://deploy-preview-1120--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit c1f37c7
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/66ef0f89bf45bc00083d3b18
😎 Deploy Preview https://deploy-preview-1120--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit c1f37c7
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/66ef0f8978ae0f0008947b31
😎 Deploy Preview https://deploy-preview-1120--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aialok
Copy link
Contributor Author

aialok commented Jun 28, 2024

This PR is ready to review.
Thank you : )

@Shurtu-gal
Copy link
Collaborator

Is it just me or nobody is able to see the tour?

@aialok
Copy link
Contributor Author

aialok commented Jun 30, 2024

Hey @Shurtu-gal !!

It is working fine for me : https://deploy-preview-1120--modest-rosalind-098b67.netlify.app/

changes are done in : app/studio

#1120 (comment)

you can run the tour again :

image

@Shurtu-gal
Copy link
Collaborator

@aialok the changes need to be done in studio-next as well I suppose. @Amzani when are we planning to merge these two?

Also is there any scope of showing interaction to user during the tour.

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@Shurtu-gal
Copy link
Collaborator

Updates:

I have told @aialok to do a comparison b/w various option such as react-joyride and create an ADR so that we can make an informed decision. The only problem with the current implementation is the lack of interactivity (controlled elements).

@aialok
Copy link
Contributor Author

aialok commented Jul 20, 2024

@Mayaleeeee Please review the design of the popover.
@Shurtu-gal This is ready for review.

Thank you : )

@Shurtu-gal
Copy link
Collaborator

Great work @aialok 🚀.
Just need a design approval, meanwhile this can be put on slack as well, for suggestions from everyone, can cc @studio there as well.

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, that will improve our users onboarding!
In addition to my review

The close button could be improved by removing the hover
Screenshot 2024-07-23 at 10 19 16

apps/studio-next/src/helpers/driver.ts Outdated Show resolved Hide resolved
apps/studio-next/src/helpers/driver.ts Outdated Show resolved Hide resolved
@aialok
Copy link
Contributor Author

aialok commented Jul 23, 2024

Done with all the requested changes.
Thank you @Amzani : )

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a few suggestions.

apps/studio-next/src/helpers/driver.ts Outdated Show resolved Hide resolved
apps/studio-next/src/helpers/driver.ts Outdated Show resolved Hide resolved
apps/studio-next/src/helpers/driver.ts Outdated Show resolved Hide resolved
@aialok
Copy link
Contributor Author

aialok commented Jul 23, 2024

Thank you @KhudaDad414 , done with requested changes : )

@aialok
Copy link
Contributor Author

aialok commented Sep 18, 2024

Hard-locked the @asyncapi/converter on version 1.5.0 during handling incident #1138. Just a heads-up for conflict resolution.

Sure..Sure...conflict in pkg json and lock file...little hard too to do..but lemme do it : )

@Shurtu-gal
Copy link
Collaborator

@aialok there are some problems with the lock file. The deployment is failing.

@aialok
Copy link
Contributor Author

aialok commented Sep 20, 2024

@Shurtu-gal might be because there is some conflict in the lock file...I just resolve the conflict.

Can I delete lock file and generate new one and push it?

@Shurtu-gal
Copy link
Collaborator

Yeah, that would be great 😃

@aialok
Copy link
Contributor Author

aialok commented Sep 21, 2024

@Shurtu-gal I have resolved all the conflict. Please merge it. It's been so long : )
Thank you : )

@Shurtu-gal
Copy link
Collaborator

@Amzani could you please approve the workflows and approve this.
Thanks 🙏

@aialok
Copy link
Contributor Author

aialok commented Sep 21, 2024

Fixing Build failed...hold on : )

@Shurtu-gal
Copy link
Collaborator

Also @aialok could you run yarn lint as well.

@aialok
Copy link
Contributor Author

aialok commented Sep 21, 2024

Also @aialok could you run yarn lint as well.

Fixes the build : )

@aeworxet
Copy link
Contributor

@aialok Sonar still complains, this time it's justified.

#1120 (comment)

@aialok
Copy link
Contributor Author

aialok commented Sep 21, 2024

@aeworxet fixing it : )

Copy link

sonarcloud bot commented Sep 21, 2024

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aialok
Copy link
Contributor Author

aialok commented Sep 23, 2024

@Shurtu-gal It got approved now. Can we go with the merge?

@Shurtu-gal
Copy link
Collaborator

/rtm

@Shurtu-gal
Copy link
Collaborator

@Shurtu-gal It got approved now. Can we go with the merge?

Absolutely, mate 🚀. Great work!!

@asyncapi-bot asyncapi-bot merged commit fa714db into asyncapi:master Sep 23, 2024
23 checks passed
@aialok
Copy link
Contributor Author

aialok commented Sep 23, 2024

@Shurtu-gal It got approved now. Can we go with the merge?

Absolutely, mate 🚀. Great work!!

It was really fun to work with you ❤️❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Status: Done
Development

Successfully merging this pull request may close these issues.

Create onboarding for features of Studio
7 participants