feat: merge the studio next and studio apps #1141
Conversation
catosaurusrex2003
requested review from
magicmatatjahu,
KhudaDad414,
Amzani and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 40d1058 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for studio-next failed.
|
|
@catosaurusrex2003 could you resolve the conflicts. |
|
#1120 was merged just now. |
|
very beautiful PR 🤩 |
…nning in dev, build is failing tho due to linting config issues.
|
@Shurtu-gal |
Yeah, I have tagged @fmvilas in a previous comment regarding this. |
|
Thanks for the ping, @Shurtu-gal. It's working now 👍 |
Great. Thanks 🥇 |
|
@catosaurusrex2003 please check the failing tests |
|
@Shurtu-gal i fixed the ones failing due to linting The ones failing now are due to a missing |
|
@Shurtu-gal |
Yeah, I have already talked with him and we are doing that. Also @fmvilas I think there is some problem with the config as the share feature is working in both mine and @catosaurusrex2003 deploys. |
|
I will fix the Sonar Cloud Issues by tomorrow. Just need to correct the netlify config for functions. |
I was going through the sonarcloud issues. Most of them were already present and we don't have a trivial way of solving the I have fixed the multiple react problems though and added a change-set. Going ahead with the merge. |
|
|
/rtm |
Description
In the first commit, I made necessary changes to the package.json files located both in the root directory and within the studio-next folder. (Please refer to this specific commit to review the changes, as in the subsequent commit I deleted the entire studio folder along with its files.)
After these changes, I thoroughly checked for any regressions or differences between the studio-next app and the currently deployed version of the site.
I did not find any discrepancies or issues during this process.
Resolves Issue: #1134
Some questions i have
studio-next, or should we maintain the versioning from the oldstudiofolder?This is my first time performing a migration within a monorepo structure, and I would appreciate any guidance or feedback on best practices and to ensure the migration process follows the project's conventions.