Skip to content

Commit

Permalink
Push REPO_VERSION var into containers for builds
Browse files Browse the repository at this point in the history
Set `REPO_VERSION` via Podman and Docker container run commands
to properly have any externally set value (e.g., GitHub Actions)
inherited by the container build environment.

See also:

- atc0005/shared-project-resources#208
  • Loading branch information
atc0005 committed Jul 31, 2024
1 parent 07a2f3e commit dd1fc8a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,7 @@ docker-release-build: clean helper-builder-setup
@echo
@echo "Using release builder image to generate project release assets"
$(CONTAINER_COMMAND) container run \
--env REPO_VERSION=$(REPO_VERSION) \
--user builduser:builduser \
--rm \
-i \
Expand All @@ -826,6 +827,7 @@ podman-release-build: clean helper-builder-setup
@echo
@echo "Using release builder image to generate project release assets"
$(CONTAINER_COMMAND) container run \
--env REPO_VERSION=$(REPO_VERSION) \
--rm \
-i \
-v $$PWD/$(OUTPUTDIR):/builds/$(OUTPUTDIR):rw \
Expand All @@ -845,6 +847,7 @@ docker-dev-build: clean helper-builder-setup
@echo
@echo "Using release builder image to generate project release assets"
$(CONTAINER_COMMAND) container run \
--env REPO_VERSION=$(REPO_VERSION) \
--user builduser:builduser \
--rm \
-i \
Expand All @@ -865,6 +868,7 @@ podman-dev-build: clean helper-builder-setup
@echo
@echo "Using release builder image to generate project release assets"
$(CONTAINER_COMMAND) container run \
--env REPO_VERSION=$(REPO_VERSION) \
--rm \
-i \
-v $$PWD/$(OUTPUTDIR):/builds/$(OUTPUTDIR):rw \
Expand All @@ -886,6 +890,7 @@ docker-packages: helper-builder-setup

@echo "Building with $(CONTAINER_COMMAND)"
$(CONTAINER_COMMAND) container run \
--env REPO_VERSION=$(REPO_VERSION) \
--rm \
--user builduser:builduser \
-i \
Expand All @@ -908,6 +913,7 @@ podman-packages: helper-builder-setup

@echo "Building with $(CONTAINER_COMMAND)"
$(CONTAINER_COMMAND) container run \
--env REPO_VERSION=$(REPO_VERSION) \
--rm \
-i \
-v $$PWD/$(OUTPUTDIR):/builds/$(OUTPUTDIR):rw \
Expand Down

0 comments on commit dd1fc8a

Please sign in to comment.