Reuse tag instead of calculating for release build #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile used by dependenent projects attempts to reuse the `REPO_VERSION` environment variable if set, otherwise falls back to generating a new value using `git-describe-semver`. This tool becomes confused if two tags point to the same commit and does not know which tag to list (ideally the latest stable tag if matching the same commit as a RC tag) so we work around that by always having release builds use the tag provided by GitHub Actions (which matches exactly the tag pushed).
atc0005
added a commit
to atc0005/safelinks
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/safelinks
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/send2teams
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/send2teams
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/tsm-pass
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/tsm-pass
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/nagios-debug
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/nagios-debug
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/query-meta
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/query-meta
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/dnsc
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/dnsc
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-process
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-restart
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-restart
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-rsat
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-rsat
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-ssh
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-ssh
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-statuspage
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-statuspage
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-vmware
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-vmware
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-whois
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/check-whois
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/mysql2sqlite
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
atc0005
added a commit
to atc0005/mysql2sqlite
that referenced
this pull request
Jul 31, 2024
Set `REPO_VERSION` via Podman and Docker container run commands to properly have any externally set value (e.g., GitHub Actions) inherited by the container build environment. See also: - atc0005/shared-project-resources#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile used by dependenent projects attempts to reuse the
REPO_VERSIONenvironment variable if set, otherwise falls back to generating a new value usinggit-describe-semver.This tool becomes confused if two tags point to the same commit and does not know which tag to list (ideally the latest stable tag if matching the same commit as a RC tag) so we work around that by always having release builds use the tag provided by GitHub Actions (which matches exactly the tag pushed).