Resolve intermittent user mention failure #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atc0005
added
bug
OVERVIEW
Resolve intermittent user mention submission failure by swapping out
the `botapi` implementation of user mention support for the new
`adaptivecard` package. This new package generates payloads with user
mentions that fully comply with published Microsoft Teams requirements.
Temporary restrictions applied in the last release between user
mentions and the URL "buttons", title flags have been removed.
This app now exclusively uses the `adaptivecard` package.
Unfortunately, the `Adaptive Card` format does not (at the time of
this writing) support message color theming (border trim color). This
flag now is a NOOP; while using this flag does not produce an error,
it no longer does anything.
CHANGES
- replace `botapi` and `messagecard` packages with `adaptivecard`
package
- exclusively use `adaptivecard` package to generate Microsoft Teams
messages
- add missing checks for use of `--silent` flag before emitting
warning/error output
- resolve intermittent user mention submission failure
- the `--target-url` flag no longer enforces a set limit of 4 URL
"buttons"
- documentation
- the current Microsoft Teams message size limit of
*approximately* 28 KB is explicitly noted
- references to the `--color` flag have been removed (aside
from the explicit NOOP behavior in the config flag table)
- mention that the generated JSON payload is now emitted in
verbose ouput (exposed via the `--verbose` flag)
REFERENCES
- refs GH-225
- refs atc0005/go-teams-notify#162
atc0005
force-pushed
the
i225-resolve-intermittent-user-mention-submission-failure
branch
from
ec30067
to
fc8be76
Compare
atc0005
deleted the
i225-resolve-intermittent-user-mention-submission-failure
branch
This was referenced Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolve intermittent user mention submission failure by swapping out the
botapiimplementation of user mention support for the newadaptivecardpackage. This new package generates payloads with user mentions that fully comply with published Microsoft Teams requirements.Temporary restrictions applied in the last release between user mentions and the URL "buttons", title flags have been removed.
This app now exclusively uses the
adaptivecardpackage. Unfortunately, theAdaptive Cardformat does not (at the time of this writing) support message color theming (border trim color). This flag now is a NOOP; while using this flag does not produce an error, it no longer does anything.Changes
botapiandmessagecardpackages withadaptivecardpackageadaptivecardpackage to generate Microsoft Teams messages--silentflag before emitting warning/error output--target-urlflag no longer enforces a set limit of 4 URL "buttons"--colorflag have been removed (aside from the explicit NOOP behavior in the config flag table)verbose ouput (exposed via the
--verboseflag)References
--user-mentionflag #225