Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve intermittent user mention failure #228

Merged

Commits on Apr 11, 2022

  1. Resolve intermittent user mention failure

    OVERVIEW
    
    Resolve intermittent user mention submission failure by swapping out
    the `botapi` implementation of user mention support for the new
    `adaptivecard` package. This new package generates payloads with user
    mentions that fully comply with published Microsoft Teams requirements.
    
    Temporary restrictions applied in the last release between user
    mentions and the URL "buttons", title flags have been removed.
    
    This app now exclusively uses the `adaptivecard` package.
    Unfortunately, the `Adaptive Card` format does not (at the time of
    this writing) support message color theming (border trim color). This
    flag now is a NOOP; while using this flag does not produce an error,
    it no longer does anything.
    
    CHANGES
    
    - replace `botapi` and `messagecard` packages with `adaptivecard`
      package
    - exclusively use `adaptivecard` package to generate Microsoft Teams
      messages
    - add missing checks for use of `--silent` flag before emitting
      warning/error output
    - resolve intermittent user mention submission failure
    - the `--target-url` flag no longer enforces a set limit of 4 URL
      "buttons"
    - documentation
        - the current Microsoft Teams message size limit of
          *approximately* 28 KB is explicitly noted
        - references to the `--color` flag have been removed (aside
          from the explicit NOOP behavior in the config flag table)
        - mention that the generated JSON payload is now emitted in
          verbose ouput (exposed via the `--verbose` flag)
    
    REFERENCES
    
    - refs GH-225
    - refs atc0005/go-teams-notify#162
    atc0005 committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    fc8be76 View commit details
    Browse the repository at this point in the history