Skip to content

Commit

Permalink
TRY to run depsinstall Makefile recipe
Browse files Browse the repository at this point in the history
- remove the depsinstall input
- run the depsinstall Makefile recipe explicitly, but
  mark it as OK to fail without failing the whole job

This works around limited implementation of the new Makefile
recipe across dependent projects.

refs GH-71
  • Loading branch information
atc0005 committed Feb 23, 2023
1 parent 172099d commit d8e89b8
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/lint-and-build-using-make.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ on:
gogeninstall:
required: false
type: boolean
depsinstall:
required: false
type: boolean

jobs:
lint_code_with_makefile:
Expand Down Expand Up @@ -123,9 +120,13 @@ jobs:
echo "See https://github.com/atc0005/shared-project-resources/issues/71 for details."
exit 1
- name: Install build dependencies (if requested)
# Try to install build dependencies using the depsinstall Makefile
# recipe but allow this step to fail without failing the whole job if
# the recipe is not yet implemented by a project's Makfile.
- name: Install build dependencies (try)
if: inputs.depsinstall
run: make depsinstall
continue-on-error: true

- name: Build using project Makefile
run: make all

0 comments on commit d8e89b8

Please sign in to comment.