Replace gogeninstall input with explicit depsinstall Makefile recipe call
#71
Assignees
Labels
Comments
atc0005
added a commit
that referenced
this issue
Feb 23, 2023
- remove conditional shallow/full git clone step, force full
history clone by default to allow build tooling access to
all tags
- flag use of input as deprecated, fail workflow step if used
- add (optional) depsinstall input, Makefile recipe call of
the same name
- NOTE: this will likely become set to true by default
after enough projects have been updated to provide this
Makefile recipe
refs GH-71
This was referenced Feb 23, 2023
atc0005
added a commit
to atc0005/check-cert
that referenced
this issue
Feb 23, 2023
The distinction between "go generate" and general build dependencies isn't important enough to maintain separate Makefile recipes. refs atc0005/shared-project-resources#71
atc0005
added a commit
to atc0005/check-cert
that referenced
this issue
Feb 23, 2023
The distinction between "go generate" and general build dependencies isn't important enough to maintain separate Makefile recipes. refs atc0005/shared-project-resources#71
atc0005
added a commit
to atc0005/check-mail
that referenced
this issue
Feb 23, 2023
The distinction between "go generate" and general build dependencies isn't important enough to maintain separate Makefile recipes. refs atc0005/shared-project-resources#71
atc0005
changed the title
gogeninstall input with depsinstall inputgogeninstall input with explicit depsinstall Makefile recipe call
atc0005
added a commit
that referenced
this issue
Feb 23, 2023
- remove the depsinstall input - run the depsinstall Makefile recipe explicitly, but mark it as OK to fail without failing the whole job This works around limited implementation of the new Makefile recipe across dependent projects. refs GH-71
atc0005
added a commit
that referenced
this issue
Feb 23, 2023
I meant to remove this in the last commit. refs GH-71
This was referenced Feb 23, 2023
atc0005
added a commit
that referenced
this issue
Feb 24, 2023
Confirmed that no dependent projects are using it, so removing it while I am still thinking about it. refs GH-71
atc0005
added a commit
that referenced
this issue
Mar 1, 2023
This was missed with recent cleanup work. refs GH-71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The original idea was to conditionally toggle:
gogeninstallrecipe usebased on what the calling workflow specified via an optional
gogeninstallinput.Recent projects refactoring work has deprecated that Makefile recipe. The
depsinstallMakefile is replacing it, but hasn't been implemented broadly yet. Until it is we should allow calls for that recipe to fail without failing the whole job.The text was updated successfully, but these errors were encountered: