Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move topology files from pce to datamodel #104

Merged
merged 33 commits into from
Aug 16, 2023
Merged

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 11, 2023

Fixes #103. Changes:

  • Copies amlight.json, sax.json, and zaoxi.json from pce to src/sdx_datamodel/data/topologies so that they will included in the Python package.
  • Also copies ampath.json and sdx.json to that location from test data directory for good measure, although I am not entirely sure of their usage -- they can perhaps be removed now or eventually?
  • Copies test_request.json and test_request_no_node.json from pce to src/sdx_datamodel/data/requests. Also copies p2p.json to the same path, as test_request_p2p.json.
  • Expands test coverage for topology/connection handlers and validators, so that some more cases are tested.
  • Adds a tox configuration so that tests can be run with several versions of Python.
  • Formats all concerned JSON files (with python3 -m json.tool <infile> <outfile>.

@sajith sajith self-assigned this Aug 11, 2023
@coveralls
Copy link

coveralls commented Aug 11, 2023

Pull Request Test Coverage Report for Build 5859849091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 74.635%

Totals Coverage Status
Change from base Build 5800666242: 0.5%
Covered Lines: 1029
Relevant Lines: 1247

💛 - Coveralls

@sajith sajith marked this pull request as ready for review August 15, 2023 18:55
@sajith sajith requested a review from YufengXin August 15, 2023 18:55
@sajith sajith linked an issue Aug 16, 2023 that may be closed by this pull request
@YufengXin
Copy link
Collaborator

sdx.json was the combined topology from the three domain topologies. I kept it for certain unitests related to pce because it works on the combined inter domain topology.

ampath.json might be a temporary file in early days. We probably could remove it later.

@sajith sajith merged commit 2548a8e into main Aug 16, 2023
@sajith sajith deleted the 103.topology-files-refactoring branch August 16, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Move static topology files once again Test with tox
3 participants