-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move topology files from pce to datamodel #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5859849091
💛 - Coveralls |
Closed
sdx.json was the combined topology from the three domain topologies. I kept it for certain unitests related to pce because it works on the combined inter domain topology. ampath.json might be a temporary file in early days. We probably could remove it later. |
YufengXin
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103. Changes:
amlight.json
,sax.json
, andzaoxi.json
from pce tosrc/sdx_datamodel/data/topologies
so that they will included in the Python package.ampath.json
andsdx.json
to that location from test data directory for good measure, although I am not entirely sure of their usage -- they can perhaps be removed now or eventually?test_request.json
andtest_request_no_node.json
from pce tosrc/sdx_datamodel/data/requests
. Also copiesp2p.json
to the same path, astest_request_p2p.json
.python3 -m json.tool <infile> <outfile>
.