Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static topology files from datamodel #153

Merged
merged 12 commits into from
Aug 21, 2023
Merged

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 15, 2023

With this PR:

  • All static topology and connection request files will reside in datamodel, and nowhere else.
  • In unit tests, pce will use those static files from datamodel.

For reference, topology files were moved to datamodel in atlanticwave-sdx/datamodel#104.

@sajith sajith self-assigned this Aug 15, 2023
@coveralls
Copy link

coveralls commented Aug 15, 2023

Pull Request Test Coverage Report for Build 5926089666

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.058%

Totals Coverage Status
Change from base Build 5808566243: 0.0%
Covered Lines: 840
Relevant Lines: 1025

💛 - Coveralls

@sajith sajith marked this pull request as ready for review August 16, 2023 19:11
@sajith sajith requested a review from YufengXin August 16, 2023 19:12
@sajith sajith merged commit 793b4d9 into main Aug 21, 2023
@sajith sajith deleted the 103.topology-in-datamodel branch August 21, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants