ARC-916 - GHE UI: Connect GitHub Enterprise Server page #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krazziekay
requested review from
rachellerathbone and
yvonnevictoria
and removed request for
yvonnevictoria and
rachellerathbone
joshkay10
reviewed
Jun 9, 2022
rachellerathbone
requested changes
Jun 10, 2022
- Px converted to em and rem - Type annotation updated for `checkValidUrl` - Class names updated - target added for a links
joshkay10
reviewed
Jun 10, 2022
joshkay10
reviewed
Jun 10, 2022
joshkay10
reviewed
Jun 10, 2022
|
I just pulled your branch to have a look at the UI locally and the font looks really small. Remember, when working in the iframe you can't use the exact measurements that you see in Figma because we're working with a smaller real estate thanks to the left panel and navigation. Makes it hard to figure out the exact measurements but you should be able to look at the design and your rendering and not really see any differences. The font in the UI is noticeably smaller. |
rachellerathbone
approved these changes
Jun 14, 2022
krazziekay
added a commit
that referenced
this pull request
Jun 14, 2022
This reverts commit dd5122e.
krazziekay
added a commit
that referenced
this pull request
Jun 14, 2022
|
This PR was accidentally merged before testing in staging. So has been reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Changes
Added a new view
hbs, with its respectivejsandcssfileThe view has an empty field and a disabled button by default.
The button is enabled once the input field has some value.
For any invalid URLs typed, the error message is displayed once you click on the button.
For a valid URL typed, clicking on the button will simply change the text on the button to a spinner. (Nothing will happen for now)
Whats not done
Learn MoreNextbutton.github.com