Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARC-916 - GHE UI: Connect GitHub Enterprise Server page #1267

Merged
merged 24 commits into from
Jun 14, 2022
Merged

ARC-916 - GHE UI: Connect GitHub Enterprise Server page #1267

merged 24 commits into from
Jun 14, 2022

Conversation

krazziekay
Copy link
Collaborator

Rationale

  • This PR includes the addition of a new view where users can add the URL for their GHE server.

Changes

  • Added a new view hbs, with its respective js and css file

  • The view has an empty field and a disabled button by default.
    Screen Shot 2022-06-09 at 3 46 48 pm

  • The button is enabled once the input field has some value.
    Screen Shot 2022-06-09 at 3 47 14 pm

  • For any invalid URLs typed, the error message is displayed once you click on the button.
    Screen Shot 2022-06-09 at 4 09 14 pm
    Screen Shot 2022-06-09 at 4 09 54 pm

  • For a valid URL typed, clicking on the button will simply change the text on the button to a spinner. (Nothing will happen for now)
    Screen Shot 2022-06-09 at 3 47 33 pm

Whats not done

  • URLs for the link Learn More
  • Tooltips for the QuestionMark icon.
  • The action for the Next button.
  • The links for the left arrow and the Help link.
  • The flow when user types in a GitHub Cloud url, i.e. github.com

krazziekay and others added 23 commits June 9, 2022 15:42
@krazziekay
- New View for Connecting to GHE Server added
77d7de6
@krazziekay
- Code cleanup
91e983e
@krazziekay
Merge branch 'main' of github.com:atlassian/github-for-jira into ARC-916
789fed6
@krazziekay
- Minor correction
5e68643
@krazziekay
- Trailing slashes removed
1c68dae
@krazziekay
- Trailing slashes removed
4abde4b
@krazziekay
- some replaced by includes for protocal check
a1797f4
@krazziekay
- Hostname check fixes
21077b6
@krazziekay
Review changes
0ebc93c 
- Px converted to em and rem
- Type annotation updated for `checkValidUrl`
- Class names updated
- target added for a links
@krazziekay
Merge branch 'main' into ARC-916
8593640
@krazziekay
- Text changes
e1bccdd
@krazziekay
Merge branch 'ARC-916' of github.com:atlassian/github-for-jira into A…
d7bde2e 
…RC-916
@krazziekay
Merge branch 'main' into ARC-916
087eaa5
@krazziekay
- Review changes
fe795be
@krazziekay
Merge branch 'main' into ARC-916
af36155
@krazziekay
- Removed white spaces
8fe5938
@krazziekay
- minor correction
7cd4d80
@krazziekay
Merge branch 'main' into ARC-916
1c0ad71
@krazziekay
- Minor increment in the font sizes and margins
738b10d
@krazziekay
Merge remote-tracking branch 'origin/ARC-916' into ARC-916
491cf4a
@krazziekay
- Minor increment in the font sizes and margins
0c01ae7
@krazziekay
Merge branch 'main' into ARC-916
f87d564
@krazziekay
Merge branch 'main' into ARC-916
281c21b
@krazziekay krazziekay requested a review from a team as a code owner June 14, 2022 07:05
@krazziekay krazziekay self-assigned this Jun 14, 2022
@krazziekay krazziekay mentioned this pull request Jun 14, 2022
Merged
@krazziekay krazziekay merged commit a3ab6f8 into main Jun 14, 2022
@krazziekay krazziekay deleted the ARC-916 branch June 14, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachellerathbone rachellerathbone rachellerathbone approved these changes

Assignees

@krazziekay krazziekay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krazziekay @rachellerathbone